Bug 71529

Summary: [chromium] Write unit tests for compositor-thread zooming
Product: WebKit Reporter: Alexandre Elias <aelias>
Component: New BugsAssignee: Alexandre Elias <aelias>
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, cc-bugs, jamesr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Alexandre Elias 2011-11-03 17:58:37 PDT 
[chromium] Write unit tests for compositor-thread zooming
Comment 1 Alexandre Elias 2012-01-20 15:38:42 PST 
Created attachment 123396 [details]
Patch
Comment 2 Alexandre Elias 2012-01-20 15:40:15 PST 
Finally got around to writing some tests for this.  Please take a look.
Comment 3 James Robinson 2012-01-20 16:01:36 PST 
Comment on attachment 123396 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123396&action=review

R=me

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:181
> +    const float minPageScale = 0.5f, maxPageScale = 4;

nit: webkit style is to define these sorts of literals as "0.5" without the trailing "f"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:219
> +        float pageScaleDelta = 0.1f;

same here: WK style prefers "0.1"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:240
> +    const float minPageScale = 0.5f, maxPageScale = 4;

ditto
Comment 4 Alexandre Elias 2012-01-20 16:05:51 PST 
Created attachment 123400 [details]
Patch
Comment 5 James Robinson 2012-01-20 16:24:36 PST 
Comment on attachment 123400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123400&action=review

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:275
> +        expectContains(*scrollInfo.get(), scrollLayer->id(), IntSize(-50, -50));

FYI for the future, with WebKit smart pointers doing *ptr is the same as *ptr.get()
Comment 6 WebKit Review Bot 2012-01-20 19:19:25 PST 
Comment on attachment 123400 [details]
Patch

Clearing flags on attachment: 123400

Committed r105566: <http://trac.webkit.org/changeset/105566>
Comment 7 WebKit Review Bot 2012-01-20 19:19:30 PST 
All reviewed patches have been landed.  Closing bug.