Bug 71474

Summary: [GTK] Show url of history items in a status bar in MiniBrowser
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 71466    
Bug Blocks: 71447    
Attachments:
Description Flags
Patch mrobinson: review+

Description Carlos Garcia Campos 2011-11-03 07:37:31 PDT
We used a GtkStatusbar for that, but I think we can use a GtkOverlay instead.
Comment 1 Carlos Garcia Campos 2011-11-03 07:44:12 PDT
Created attachment 113491 [details]
Patch
Comment 2 Martin Robinson 2011-11-03 09:17:37 PDT
Comment on attachment 113491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113491&action=review

Okay.

> Tools/MiniBrowser/gtk/BrowserWindow.c:43
> +    GtkWidget *statusLabel;

statusLabel -> statusOverlay ?

> Tools/MiniBrowser/gtk/BrowserWindow.c:58
> +#if GTK_CHECK_VERSION(3, 2, 0)

So it begins. :(

> Tools/MiniBrowser/gtk/BrowserWindow.c:66
> +    browserWindowSetStatusText(window, 0);

0 -> NULL

> Tools/MiniBrowser/gtk/BrowserWindow.c:106
> +    browserWindowSetStatusText(window, action ? gtk_action_get_name(action) : 0);

0 -> NULL

> Tools/MiniBrowser/gtk/BrowserWindow.c:268
> +    window->statusLabel = gtk_label_new(0);

0 -> NULL
Comment 3 Carlos Garcia Campos 2011-11-03 10:07:09 PDT
Committed r99207: <http://trac.webkit.org/changeset/99207>