Bug 71466

Summary: [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: pnormand, xan.lopez
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on: 71461    
Bug Blocks: 71447, 71474    
Attachments:
Description Flags
Patch mrobinson: review+

Carlos Garcia Campos
Reported 2011-11-03 06:34:16 PDT
Add a menu to back and forward toolbar buttons.
Attachments
Patch (4.72 KB, patch)
2011-11-03 06:39 PDT, Carlos Garcia Campos 		mrobinson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2011-11-03 06:39:12 PDT
Created attachment 113476 [details] Patch
Martin Robinson
Comment 2 2011-11-03 09:14:48 PDT
Comment on attachment 113476 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113476&action=review > Tools/MiniBrowser/gtk/BrowserWindow.c:101 > + return 0; 0 -> NULL > Tools/MiniBrowser/gtk/BrowserWindow.c:110 > + GtkAction *action = gtk_action_new(uri, title, 0, 0); This is C so the zeros should be NULL, I think. > Tools/MiniBrowser/gtk/BrowserWindow.c:111 > + g_object_set_data_full(G_OBJECT(action), "back-forward-list-item", g_object_ref(item), (GDestroyNotify)g_object_unref); You might not need to cast GDestroyNotify here. Please check before landing.
Carlos Garcia Campos
Comment 3 2011-11-03 10:02:01 PDT
Committed r99206: <http://trac.webkit.org/changeset/99206>
Note You need to log in before you can comment on or make changes to this bug.