Bug 71435 – Move NSRange / DOMRange conversion functions to WebFramePrivate

• Component: WebKit Misc.
• Status: RESOLVED FIXED

[Joseph Pecoraro]

Move the following from WebFrame (WebInternal) to WebFrame (WebPrivate):

  - (DOMRange *)_convertNSRangeToDOMRange:(NSRange)nsrange
  - (NSRange)_convertDOMRangeToNSRange:(DOMRange *)range

Remove the old version that were left around for Leopard but are no longer used.

[Joseph Pecoraro]

Created attachment 113421 [details]
[PATCH] Move Functions to WebFramePrivate

[WebKit Review Bot]

Comment on attachment 113421 [details]
[PATCH] Move Functions to WebFramePrivate

Clearing flags on attachment: 113421

Committed r99139: <http://trac.webkit.org/changeset/99139>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 113421 [details]
[PATCH] Move Functions to WebFramePrivate

View in context: https://bugs.webkit.org/attachment.cgi?id=113421&action=review

> Source/WebKit/mac/WebView/WebFrame.mm:-695
> -- (DOMRange *)convertNSRangeToDOMRange:(NSRange)nsrange
> -{
> -    // This method exists to maintain compatibility with Leopard's Dictionary.app. <rdar://problem/6002160>
> -    return [self _convertNSRangeToDOMRange:nsrange];
> -}

If removing this, we should also remove the -[WebHTMLView _bridge] method.