Bug 71409

Summary: [Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
Product: WebKit Reporter: Mahesh Kulkarni <maheshk>
Component: Plug-insAssignee: Mahesh Kulkarni <maheshk>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Mahesh Kulkarni
Reported 2011-11-02 15:04:07 PDT
Latest qt5 has removed X11 header and webkit does not build because of it. Putting under X11 PLATFORM_ARCH flag along with GTK's x11 header file as it is anyway right thing to do
Attachments
patch (1.26 KB, patch)
2011-11-02 15:11 PDT, Mahesh Kulkarni 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mahesh Kulkarni
Comment 1 2011-11-02 15:11:35 PDT
Created attachment 113383 [details] patch
Simon Hausmann
Comment 2 2011-11-03 00:22:28 PDT
Comment on attachment 113383 [details] patch I guess that'll do as a build fix as it's consistent with the usage the same guards around QX11Info later in the file. But I think the correct fix is to include QX11Info for Qt 4.x and use the QPlatformNativeInterface in Qt 5 to retrieve the display. I admit that requires more than just a build fix, so r=me for this one :)
WebKit Review Bot
Comment 3 2011-11-03 00:36:44 PDT
Comment on attachment 113383 [details] patch Clearing flags on attachment: 113383 Committed r99146: <http://trac.webkit.org/changeset/99146>
WebKit Review Bot
Comment 4 2011-11-03 00:36:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.