Bug 71409 - [Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
Summary: [Qt] Flagging usage of X11 headers under PLAT_ARCH(X11)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mahesh Kulkarni
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 15:04 PDT by Mahesh Kulkarni
Modified: 2011-11-03 00:36 PDT (History)
1 user (show)

See Also:

Attachments
patch (1.26 KB, patch)
2011-11-02 15:11 PDT, Mahesh Kulkarni 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mahesh Kulkarni 2011-11-02 15:04:07 PDT 
Latest qt5 has removed X11 header and webkit does not build because of it. Putting under X11 PLATFORM_ARCH flag along with GTK's x11 header file as it is anyway right thing to do
Comment 1 Mahesh Kulkarni 2011-11-02 15:11:35 PDT 
Created attachment 113383 [details]
patch
Comment 2 Simon Hausmann 2011-11-03 00:22:28 PDT 
Comment on attachment 113383 [details]
patch

I guess that'll do as a build fix as it's consistent with the usage the same guards around QX11Info later in the file. But I think the correct fix is to include QX11Info for Qt 4.x and use the QPlatformNativeInterface in Qt 5 to retrieve the display. I admit that requires more than just a build fix, so r=me for this one :)
Comment 3 WebKit Review Bot 2011-11-03 00:36:44 PDT 
Comment on attachment 113383 [details]
patch

Clearing flags on attachment: 113383

Committed r99146: <http://trac.webkit.org/changeset/99146>
Comment 4 WebKit Review Bot 2011-11-03 00:36:48 PDT 
All reviewed patches have been landed.  Closing bug.