Bug 71391

Summary: Make parameters for webaudio biquad filters consistent
Product: WebKit Reporter: Raymond Toy <rtoy>
Component: Web AudioAssignee: Raymond Toy <rtoy>
Status: RESOLVED INVALID    
Severity: Normal CC: crogers, rtoy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 71413    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Raymond Toy
Reported 2011-11-02 13:13:00 PDT
The Q parameter for the biquad filters are treated inconsistently. For all filters except lowpass and highpass filters, Q is the Q parameter, but for the LP and HP filters, Q is the resonance. The LP and HP filters should treat the Q parameter as the Q parameter instead of the resonance.
Attachments
Patch (4.76 KB, patch)
2011-11-18 11:20 PST, Raymond Toy 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Raymond Toy
Comment 1 2011-11-18 11:20:20 PST
Created attachment 115839 [details] Patch
Raymond Toy
Comment 2 2011-11-18 11:22:26 PST
Make the Q parameter consistent with the Audio EQ Cookbook. This patch needs to be coordinated with the demos that use lowpass or highpass filters because the meaning of Q has changed. Q is no longer the resonance in dB, but the actual Q factor.
Raymond Toy
Comment 3 2012-01-25 13:32:55 PST
Make this depend on bug 71413, which will add biquad tests so we can inherit the tests from there.
Chris Rogers
Comment 4 2013-05-10 17:43:28 PDT
lowpass and highpass are now in spec as resonance in decibels
Zan Dobersek
Comment 5 2013-09-05 08:31:35 PDT
Comment on attachment 115839 [details] Patch The work on this bug has ceased, removing the r? flag on the patch.
Note You need to log in before you can comment on or make changes to this bug.