Bug 71387

Summary: Plug-in snapshots are blurry in HiDPI
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, gustavo, hausmann, kbalazs, kling, mrobinson, ossy, webkit-bug-importer, xan.lopez, zoltan
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Anders Carlsson
Reported 2011-11-02 12:56:19 PDT
Plug-in snapshots are blurry in HiDPI
Attachments
Patch (3.18 KB, patch)
2011-11-02 13:00 PDT, Anders Carlsson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-11-02 12:59:25 PDT
<rdar://problem/10385393>
Anders Carlsson
Comment 2 2011-11-02 13:00:45 PDT
Created attachment 113355 [details] Patch
Adam Roben (:aroben)
Comment 3 2011-11-02 13:02:52 PDT
Comment on attachment 113355 [details] Patch Can you create a test for this with TestWebKitAPI? You could check the snapshot's dimensions, at a minimum.
Anders Carlsson
Comment 4 2011-11-02 13:04:44 PDT
(In reply to comment #3) > (From update of attachment 113355 [details]) > Can you create a test for this with TestWebKitAPI? You could check the snapshot's dimensions, at a minimum. Hmm, since the plug-in snapshot is just painted into the regular snapshot it's not really possible to check the dimensions.
Anders Carlsson
Comment 5 2011-11-02 13:06:12 PDT
Committed r99090: <http://trac.webkit.org/changeset/99090>
Csaba Osztrogonác
Comment 6 2011-11-03 00:45:25 PDT
(In reply to comment #5) > Committed r99090: <http://trac.webkit.org/changeset/99090> It broke the GTK build.
Csaba Osztrogonác
Comment 7 2011-11-03 00:50:08 PDT
(In reply to comment #5) > Committed r99090: <http://trac.webkit.org/changeset/99090> And the Qt-WK2 build too. (but it isn't a core builder, so you can't notice it)
Simon Hausmann
Comment 8 2011-11-03 02:12:00 PDT
(In reply to comment #7) > (In reply to comment #5) > > Committed r99090: <http://trac.webkit.org/changeset/99090> > > And the Qt-WK2 build too. (but it isn't a core builder, so you can't notice it) Qt builds are fixed in http://trac.webkit.org/changeset/99151. The remaining Gtk build breakage is due to the dragSession changes. Closing this bug again, it's definitely fixed :)
Simon Hausmann
Comment 9 2011-11-03 02:13:09 PDT
And http://trac.webkit.org/changeset/99149 fixed the remaining Gtk issues :)
Note You need to log in before you can comment on or make changes to this bug.