Bug 71384

Summary: Infinite recursion in RenderSVGResourceContainer::markAllClientsForInvalidation
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: SVGAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, thorton, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Test case
none
Patch none

Levi Weintraub
Reported 2011-11-02 12:22:31 PDT
Created attachment 113349 [details] Test case When there are multiple SVG resources with identical ids that reference one another, you can trigger an infinite recursion in markAllClientsForInvalidation.
Attachments
Test case (380 bytes, image/svg+xml)
2011-11-02 12:22 PDT, Levi Weintraub 		no flags
Details
Patch (20.02 KB, patch)
2011-11-02 13:46 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-11-02 12:23:50 PDT
A very simple guard on RenderSVGResourceContainer fixes this... Will upload soon. Also tracked here: http://code.google.com/p/chromium/issues/detail?id=99209
Levi Weintraub
Comment 2 2011-11-02 13:46:35 PDT
Created attachment 113370 [details] Patch
Eric Seidel (no email)
Comment 3 2011-11-02 14:47:44 PDT
Comment on attachment 113370 [details] Patch Is this a regression? or have we had thsi bug for a long time?
Levi Weintraub
Comment 4 2011-11-02 14:59:26 PDT
I'm not sure, but I don't believe it to be a recent regression.
Levi Weintraub
Comment 5 2011-11-02 15:06:34 PDT
Comment on attachment 113370 [details] Patch Thanks Darin!
WebKit Review Bot
Comment 6 2011-11-02 15:35:33 PDT
Comment on attachment 113370 [details] Patch Clearing flags on attachment: 113370 Committed r99109: <http://trac.webkit.org/changeset/99109>
WebKit Review Bot
Comment 7 2011-11-02 15:35:37 PDT
All reviewed patches have been landed. Closing bug.
Tim Horton
Comment 8 2011-11-10 13:20:55 PST
*** Bug 69286 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.