| Summary: | Remove initErrorEvent method | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dominic Cooney <dominicc> | ||||
| Component: | DOM | Assignee: | Dominic Cooney <dominicc> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, darin, ojan, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 68791 | ||||||
| Attachments: |
|
||||||
|
Description
Dominic Cooney
2011-11-01 16:40:21 PDT
Created attachment 113260 [details]
Patch
Comment on attachment 113260 [details]
Patch
Kill all the inits!
(In reply to comment #0) > Nobody uses this, so we should un-ship it. How do we know nobody uses it? (In reply to comment #3) > (In reply to comment #0) > > Nobody uses this, so we should un-ship it. > > How do we know nobody uses it? We don't know it definitively, but the init*event methods other than for mouse and key events are rarely used and they are being removed from the specs. I think there's a very low risk of sites depending on this. (In reply to comment #3) > How do we know nobody uses it? We think nobody uses it, because this search has no results: <http://codesearch.google.com/#search/&q=initErrorEvent%20lang:js&type=cs> And manually inspecting this broader set of search results didn't turn up any uses: <http://codesearch.google.com/#search/&q=initErrorEvent> Naturally this is not a 100% robust method for determining whether it is used. Comment on attachment 113260 [details] Patch Clearing flags on attachment: 113260 Committed r99021: <http://trac.webkit.org/changeset/99021> All reviewed patches have been landed. Closing bug. |