Bug 71312 – until use_skia=1 by default on mac, default port is chromium-cg-mac

• Component: Tools / Tests
• Status: RESOLVED FIXED

Until we finally resolve http://code.google.com/p/chromium/issues/detail?id=101731 ('re-enable use_skia by default'), rniwa has noted that we should change the default port for layout_tests on mac back to chromium-cg-mac.  Otherwise, results will be compared against Skia baselines, even though the code is build with CG instead of Skia.

Created attachment 113206 [details]
Patch

This patch reverts elements of *both* of the following changes, which should have been made together in the first place:

http://trac.webkit.org/changeset/95850 (changed default CPU port for mac from chromium-cg-mac to chromium-mac)

http://trac.webkit.org/changeset/98992 (changed default GPU port for mac from chromium-gpu-cg-mac to chromium-gpu-mac)


Once we set use_skia=1 by default, we should revert this patch.

[Adam Barth]

I'm confused.  I thought we were enabling Skia by default Real Soon Now (tm).

(In reply to comment #3)
> I'm confused.  I thought we were enabling Skia by default Real Soon Now (tm).

See http://code.google.com/p/chromium/issues/detail?id=101731 ... I made that change this morning, but it caused a significant performance regression so I backed it out.

This patch will help deconfuse other developers (hopefully) by making the default layout_tests port match the version that gets built.

[Adam Barth]

Comment on attachment 113206 [details]
Patch

Ah thanks.

I will commit this tomorrow morning so I can keep an eye on things...

[WebKit Review Bot]

Comment on attachment 113206 [details]
Patch

Clearing flags on attachment: 113206

Committed r99068: <http://trac.webkit.org/changeset/99068>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.