Bug 71301

Summary: Web Inspector: load source maps via front-end host.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, dglazkov, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch yurys: review+

Pavel Podivilov
Reported 2011-11-01 10:17:46 PDT
Web Inspector: load source maps via front-end host.
Attachments
Patch (37.41 KB, patch)
2011-11-01 10:20 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (41.59 KB, patch)
2011-11-02 10:14 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (42.29 KB, patch)
2011-11-03 06:18 PDT, Pavel Podivilov 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-11-01 10:20:46 PDT
Created attachment 113187 [details] Patch
WebKit Review Bot
Comment 2 2011-11-01 12:33:42 PDT
Comment on attachment 113187 [details] Patch Attachment 113187 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10259031 New failing tests: inspector/debugger/raw-source-code.html
Pavel Podivilov
Comment 3 2011-11-02 10:14:03 PDT
Created attachment 113326 [details] Patch
Yury Semikhatsky
Comment 4 2011-11-03 01:22:23 PDT
Could you provide more context and explain why this change is necessary?
Yury Semikhatsky
Comment 5 2011-11-03 01:29:13 PDT
Comment on attachment 113326 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113326&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:97 > + callback(true); The function is synchronous, why not get rid of the callback and return the value?
Pavel Podivilov
Comment 6 2011-11-03 04:25:23 PDT
(In reply to comment #4) > Could you provide more context and explain why this change is necessary? Done
Pavel Podivilov
Comment 7 2011-11-03 06:18:17 PDT
Created attachment 113472 [details] Patch
Pavel Podivilov
Comment 8 2011-11-03 06:18:41 PDT
(In reply to comment #5) > (From update of attachment 113326 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=113326&action=review > > > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:97 > > + callback(true); > > The function is synchronous, why not get rid of the callback and return the value? Done.
Yury Semikhatsky
Comment 9 2011-11-09 23:29:17 PST
Comment on attachment 113472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113472&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:262 > + m_frontendPage->mainFrame()->loader()->loadResourceSynchronously(request, DoNotAllowStoredCredentials, error, response, data); What if load fails? We should notify user somehow.
Yury Semikhatsky
Comment 10 2011-11-09 23:30:54 PST
Comment on attachment 113472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113472&action=review > Source/WebCore/inspector/front-end/CompilerSourceMapping.js:91 > + load: function(callback) Unused param.
Pavel Podivilov
Comment 11 2011-11-10 01:20:10 PST
Committed r99823: <http://trac.webkit.org/changeset/99823>
Note You need to log in before you can comment on or make changes to this bug.