Summary: | Change values for WEBKIT_KEYFRAMES_RULE, WEBKIT_KEYFRAME_RULE | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, cmarrin, dglazkov, dino, eoconnor, igor.oliveira, macpherson, menard, ojan, simon.fraser, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-11-01 09:47:46 PDT
We should do this to help move animations forward. Created attachment 126529 [details]
Patch
Patch for review
Comment on attachment 126529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126529&action=review Please add a test to verify the correct values > Source/WebCore/ChangeLog:8 > + No tests. We really should have a test. The fact that we didn't before means the error in the values went undetected. Created attachment 126532 [details]
Patch
Added test per cmarrin's review
Comment on attachment 126532 [details]
Patch
Where is the expected file change?
i think we do not need changes in expected file, because with the change in the test case, it will just show things in the screen if the test fails. 1(In reply to comment #5) > (From update of attachment 126532 [details]) > Where is the expected file change? (In reply to comment #6) > i think we do not need changes in expected file, because with the change in the test case, it will just show things in the screen if the test fails. > > 1(In reply to comment #5) > > (From update of attachment 126532 [details] [details]) > > Where is the expected file change? We need as shouldBe will display : PASS window.CSSRule.WEBKIT_KEYFRAMES_RULE is 7 ... when the condition is verified. The existing -expected file is full of PASS ... is .... :D Created attachment 126535 [details]
Patch
Updated -expected per Alexis' comment.
(In reply to comment #8) > Created an attachment (id=126535) [details] > Patch > > Updated -expected per Alexis' comment. Cool thanks. Comment on attachment 126535 [details] Patch Attachment 126535 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11473735 New failing tests: animations/animation-css-rule-types.html animations/keyframes-rule.html Created attachment 126557 [details]
Patch
Fixed failing test and removed redundant changes from the other test.
Comment on attachment 126557 [details] Patch Clearing flags on attachment: 126557 Committed r107470: <http://trac.webkit.org/changeset/107470> All reviewed patches have been landed. Closing bug. |