Bug 71286

Summary: chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
Product: WebKit Reporter: epoger
Component: Tools / TestsAssignee: epoger
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

epoger
Reported 2011-11-01 07:56:42 PDT
chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
Attachments
Patch (1.23 KB, patch)
2011-11-01 07:59 PDT, epoger 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
epoger
Comment 1 2011-11-01 07:57:32 PDT
(this should be kept in sync with what port we default to on mac, chromium-mac or chromium-cg-mac)
epoger
Comment 2 2011-11-01 07:59:44 PDT
Created attachment 113172 [details] Patch
Stephen White
Comment 3 2011-11-01 10:25:55 PDT
Comment on attachment 113172 [details] Patch Elliot assures me this will only affect the trybots, and not the waterfall bots, so assuming that's true, this looks good. :) r=me
epoger
Comment 4 2011-11-01 10:28:01 PDT
The need for this change is to fix chromium trybot behavior as noted in http://codereview.chromium.org/8384004/ ('Set use_skia=1 by default'): currently, the trybots are evaluating webkit_tests against the "chromium-mac-snowleopard" port (i.e. Skia), but evaluating webkit_gpu_tests against the "chromium-gpu-cg-mac-snowleopard" port (CG). Note that this change will not affect the chromium.webkit waterfall, because those bots already manually specify either chromium-gpu-mac or chromium-gpu-cg-mac.
WebKit Review Bot
Comment 5 2011-11-01 12:29:07 PDT
Comment on attachment 113172 [details] Patch Clearing flags on attachment: 113172 Committed r98992: <http://trac.webkit.org/changeset/98992>
WebKit Review Bot
Comment 6 2011-11-01 12:29:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.