Bug 71280 – [Qt] Merge common desktop and touch APIs under an abstract base class.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jocelyn Turcotte]

[Qt] Merge common desktop and touch APIs under an abstract base class.

[Jocelyn Turcotte]

Created attachment 113157 [details]
Patch

[WebKit Review Bot]

Attachment 113157 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qabstractwebview_p.h:35:  q_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:85:  d_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alexis Menard (darktears)]

Comment on attachment 113157 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=113157&action=review

Usually in Qt abstract classes have at least one pure virtual method.

> Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:59
> +    // FIXME: We inherit from QSGPaintedItem until QDesktopWebView works on top of a plain QSGItem.

QQuickPaintedItem rather than QSGPaintedItem. QSGItem -> QQuickItem

> Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:80
> +    void linkHovered(const QUrl& url, const QString& title);

I think this should be only in the desktopwebview for now.

[Jocelyn Turcotte]

Created attachment 113174 [details]
Patch

- Renamed QAbstractWebView to QBaseWebView.
- renamed QtWebPageProxy instances from page to pageProxy.
- Changed the type of QTouchWebPagePrivate::pageProxy from QtTouchWebPageProxy to QtWebPageProxy to make its scope simillar to Q*WebView.
- Moved linkHovered back to QDesktopWebView.

[WebKit Review Bot]

Attachment 113174 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/qt/qbasewebview_p.h:35:  q_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/qbasewebview.h:84:  d_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 2 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

Comment on attachment 113174 [details]
Patch

Me gusta.

[Jocelyn Turcotte]

Comment on attachment 113174 [details]
Patch

Clearing flags on attachment: 113174

Committed r98973: <http://trac.webkit.org/changeset/98973>

[Jocelyn Turcotte]

All reviewed patches have been landed.  Closing bug.

[Alexis Menard (darktears)]

(In reply to comment #8)
> All reviewed patches have been landed.  Closing bug.

http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/14403/steps/API%20tests/logs/stdio

it broke the QML API tests.

[Jocelyn Turcotte]

Fixed the API tests.

Committed r99073: <http://trac.webkit.org/changeset/99073>