Bug 71260
| Summary: | Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Layout and Rendering | Assignee: | Darin Adler <darin> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | darin, hyatt, mihnea, mitz, simon.fraser, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar, MakingBotsRed |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr98879%20(19849)%2F | ||
| Bug Depends on: | |||
| Bug Blocks: | 57312 | ||
Adam Roben (:aroben)
http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr98879%20(19849)%2F
malloc_zone_malloc > malloc > fastMalloc > RenderFlowThread::setRegionRangeForBox
We're leaking in this function. Looks like we're allocating a new RenderRegionRange, storing it in a HashMap, and never deleting it.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/10374428>
Darin Adler
*** Bug 71620 has been marked as a duplicate of this bug. ***
Darin Adler
This is the same leak as 71259.
*** This bug has been marked as a duplicate of bug 71259 ***
Adam Roben (:aroben)
How are they the same? Bug 71259 is about leaks of RenderBoxRegionInfo objects, this bug is about leaks of RenderRegionRange objects.
Adam Roben (:aroben)
I guess one of those objects could own the other…
Darin Adler
Adam’s right. This is not a duplicate.
Mihnea Ovidenie
In function RenderFlowThread::removeRenderBoxRegionInfo, the RenderRegionRange* for box is removed from the map but not deleted.
Darin Adler
Yes, you can see the patch I already posted and got reviewed to fix this in bug 71620.
Darin Adler
Committed r99384: <http://trac.webkit.org/changeset/99384>