Bug 71260

Summary: Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Layout and RenderingAssignee: Darin Adler <darin>
Severity: Normal CC: darin, hyatt, mihnea, mitz, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, MakingBotsRed
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
URL: http://build.webkit.org/LeaksViewer/?url=http%3A%2F%2Fbuild.webkit.org%2F%2Fresults%2FSnowLeopard%20Intel%20Leaks%2Fr98879%20(19849)%2F
Bug Depends on:    
Bug Blocks: 57312    

Description Adam Roben (:aroben) 2011-10-31 17:58:24 PDT

malloc_zone_malloc > malloc > fastMalloc > RenderFlowThread::setRegionRangeForBox

We're leaking in this function. Looks like we're allocating a new RenderRegionRange, storing it in a HashMap, and never deleting it.
Comment 1 Radar WebKit Bug Importer 2011-10-31 17:58:56 PDT
Comment 2 Darin Adler 2011-11-05 18:19:47 PDT
*** Bug 71620 has been marked as a duplicate of this bug. ***
Comment 3 Darin Adler 2011-11-05 18:20:43 PDT
This is the same leak as 71259.

*** This bug has been marked as a duplicate of bug 71259 ***
Comment 4 Adam Roben (:aroben) 2011-11-05 18:22:29 PDT
How are they the same? Bug 71259 is about leaks of RenderBoxRegionInfo objects, this bug is about leaks of RenderRegionRange objects.
Comment 5 Adam Roben (:aroben) 2011-11-05 18:23:18 PDT
I guess one of those objects could own the other…
Comment 6 Darin Adler 2011-11-06 08:42:04 PST
Adam’s right. This is not a duplicate.
Comment 7 Mihnea Ovidenie 2011-11-06 12:37:21 PST
In function RenderFlowThread::removeRenderBoxRegionInfo, the RenderRegionRange* for box is removed from the map but not deleted.
Comment 8 Darin Adler 2011-11-06 14:24:29 PST
Yes, you can see the patch I already posted and got reviewed to fix this in bug 71620.
Comment 9 Darin Adler 2011-11-06 14:27:40 PST
Committed r99384: <http://trac.webkit.org/changeset/99384>