Bug 71235

Summary: No-svg build is broken
Product: WebKit Reporter: Viatcheslav Ostapenko <ostap73>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add #if ENABLE(SVG) to fix no-svg build krit: review+, krit: commit-queue+

Description Viatcheslav Ostapenko 2011-10-31 13:37:08 PDT 
Unguarded reference to SVGImage in RenderBox* RenderImage::embeddedContentBox() const
Comment 1 Viatcheslav Ostapenko 2011-10-31 13:41:57 PDT 
Created attachment 113081 [details]
Add #if ENABLE(SVG) to fix no-svg build
Comment 2 Dirk Schulze 2011-10-31 14:14:41 PDT 
Comment on attachment 113081 [details]
Add #if ENABLE(SVG) to fix no-svg build

LGTM. r=me
Comment 3 Alexey Proskuryakov 2011-10-31 17:04:30 PDT 
Comment on attachment 113081 [details]
Add #if ENABLE(SVG) to fix no-svg build

View in context: https://bugs.webkit.org/attachment.cgi?id=113081&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests. (OOPS!)

A patch cannot be landed with this line, pre-commit hook would forbid that.

> Source/WebCore/rendering/RenderImage.cpp:547
>      RefPtr<Image> image = m_imageResource->image();

Wouldn't the build remain broken because of unused variable?
Comment 4 Alexey Proskuryakov 2011-10-31 17:04:43 PDT 
This was already fixed.

*** This bug has been marked as a duplicate of bug 71247 ***