Bug 71235

Summary: No-svg build is broken
Product: WebKit Reporter: Viatcheslav Ostapenko <ostap73>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Add #if ENABLE(SVG) to fix no-svg build krit: review+, krit: commit-queue+

Viatcheslav Ostapenko
Reported 2011-10-31 13:37:08 PDT
Unguarded reference to SVGImage in RenderBox* RenderImage::embeddedContentBox() const
Attachments
Add #if ENABLE(SVG) to fix no-svg build (1.15 KB, patch)
2011-10-31 13:41 PDT, Viatcheslav Ostapenko 		krit: review+
krit: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Viatcheslav Ostapenko
Comment 1 2011-10-31 13:41:57 PDT
Created attachment 113081 [details] Add #if ENABLE(SVG) to fix no-svg build
Dirk Schulze
Comment 2 2011-10-31 14:14:41 PDT
Comment on attachment 113081 [details] Add #if ENABLE(SVG) to fix no-svg build LGTM. r=me
Alexey Proskuryakov
Comment 3 2011-10-31 17:04:30 PDT
Comment on attachment 113081 [details] Add #if ENABLE(SVG) to fix no-svg build View in context: https://bugs.webkit.org/attachment.cgi?id=113081&action=review > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) A patch cannot be landed with this line, pre-commit hook would forbid that. > Source/WebCore/rendering/RenderImage.cpp:547 > RefPtr<Image> image = m_imageResource->image(); Wouldn't the build remain broken because of unused variable?
Alexey Proskuryakov
Comment 4 2011-10-31 17:04:43 PDT
This was already fixed. *** This bug has been marked as a duplicate of bug 71247 ***
Note You need to log in before you can comment on or make changes to this bug.