Bug 71234

Summary: webkitpy tests depend to much on the user's environment
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, dpranke, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dpranke: review+, dpranke: commit-queue-

Eric Seidel (no email)
Reported 2011-10-31 13:31:23 PDT
webkitpy tests depend too much on the user's environment
Attachments
Patch (17.77 KB, patch)
2011-10-31 13:33 PDT, Eric Seidel (no email) 		dpranke: review+
dpranke: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-10-31 13:33:13 PDT
Created attachment 113080 [details] Patch
Dirk Pranke
Comment 2 2011-10-31 13:37:45 PDT
Did you just change the subject to be grammatically incorrect? :)
Dirk Pranke
Comment 3 2011-10-31 13:43:08 PDT
Comment on attachment 113080 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113080&action=review change looks basically good, with a few nits. > Tools/Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:187 > + # FIXME: Note we do not pass a filesystem as the "test port" magically suplies its own mock filesystem. Why add the FIXME here? > Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py:116 > + port = self.make_port(executive=executive) The whole point of this test is that we're actually testing the implementation of wdiff, so we have to use a real executive. This should be renamed to integration_test_run_wdiff() instead (I think this test predates the concept of integration tests).
Eric Seidel (no email)
Comment 4 2011-10-31 13:50:07 PDT
Thanks. Updated per your comments.
Eric Seidel (no email)
Comment 5 2011-10-31 13:51:05 PDT
Committed r98877: <http://trac.webkit.org/changeset/98877>
Note You need to log in before you can comment on or make changes to this bug.