Bug 71219

Summary: [Qt] Make QWebPreferences hold a QtWebPageProxy
Product: WebKit Reporter: Caio Marcelo de Oliveira Filho <cmarcelo>
Component: WebKit QtAssignee: Caio Marcelo de Oliveira Filho <cmarcelo>
Status: RESOLVED FIXED    
Severity: Normal CC: menard, webkit.review.bot, zoltan
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Caio Marcelo de Oliveira Filho
Reported 2011-10-31 05:37:04 PDT
Currently it holds a WKPreferencesRef, but in the future we will have features in our port that are not controlled by this C API. Changing it to hold a QtWebPageProxy is more flexible.
Attachments
Patch (15.09 KB, patch)
2011-10-31 06:16 PDT, Caio Marcelo de Oliveira Filho 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Caio Marcelo de Oliveira Filho
Comment 1 2011-10-31 06:16:26 PDT
Created attachment 113043 [details] Patch
Alexis Menard (darktears)
Comment 2 2011-10-31 06:24:20 PDT
Comment on attachment 113043 [details] Patch I think it's a good thing. At some point we will have to add APIs that are not in the C API but still public.
Andreas Kling
Comment 3 2011-10-31 06:31:59 PDT
Comment on attachment 113043 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113043&action=review Great idea, r=me! > Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:108 > - , m_preferences(0) > + , m_preferences() Remove this line completely.
Caio Marcelo de Oliveira Filho
Comment 4 2011-10-31 06:51:41 PDT
Committed r98851: <http://trac.webkit.org/changeset/98851>
Note You need to log in before you can comment on or make changes to this bug.