Bug 71213

Summary: [EFL] Added ewk_tile_memory_size_get function
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, hyuki.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
added new function
none
Added const none

Tomasz Morawski
Reported 2011-10-31 03:12:53 PDT
Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup the code.
Attachments
added new function (3.37 KB, patch)
2011-10-31 03:14 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Added const (3.39 KB, patch)
2011-11-02 00:35 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tomasz Morawski
Comment 1 2011-10-31 03:14:44 PDT
Created attachment 113029 [details] added new function
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-10-31 04:40:41 PDT
Comment on attachment 113029 [details] added new function View in context: https://bugs.webkit.org/attachment.cgi?id=113029&action=review > Source/WebKit/efl/ewk/ewk_tiled_model.cpp:347 > +size_t ewk_tile_memory_size_get(Ewk_Tile* tile) I'd make `tile' const.
Tomasz Morawski
Comment 3 2011-11-02 00:35:16 PDT
Created attachment 113284 [details] Added const
Raphael Kubo da Costa (:rakuco)
Comment 4 2011-11-02 08:01:58 PDT
LGTM.
KwangHyuk
Comment 5 2011-11-02 09:59:49 PDT
> Source/WebKit/efl/ewk/ewk_tiled_model.h:34 > +size_t ewk_tile_memory_size_get(const Ewk_Tile* t); I prefer tile instead of t although other existing API is still using it. :)
Tomasz Morawski
Comment 6 2011-11-03 00:26:23 PDT
(In reply to comment #5) > > Source/WebKit/efl/ewk/ewk_tiled_model.h:34 > > +size_t ewk_tile_memory_size_get(const Ewk_Tile* t); > > I prefer tile instead of t although other existing API is still using it. :) So, I think the "tile" name will look badly in courrent API implementation. So, it could be changed when existing API will be updated form "t" to "tile".
KwangHyuk
Comment 7 2011-11-03 02:40:00 PDT
LGTM.
WebKit Review Bot
Comment 8 2011-11-03 17:27:22 PDT
Comment on attachment 113284 [details] Added const Clearing flags on attachment: 113284 Committed r99252: <http://trac.webkit.org/changeset/99252>
WebKit Review Bot
Comment 9 2011-11-03 17:27:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.