Bug 71184

Summary: Move checkIntersection/checkEnclosure from RenderSVGModelObject to SVGRenderSupport
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED INVALID    
Severity: Normal CC: eric, pdr, rwlbuis, schenney, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 11274    
Attachments:
Description Flags
Patch none

Dirk Schulze
Reported 2011-10-30 03:52:15 PDT
I'll move checkIntersection/checkEnclosure from RenderSVGModelObject to SVGRenderSupport. Both functions are not only related to RenderSVGModelObject and its subclasses, but to all SVG renderer. Therefor SVGRenderSupport is a better place.
Attachments
Patch (10.11 KB, patch)
2011-10-30 04:01 PDT, Dirk Schulze 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2011-10-30 04:01:54 PDT
Created attachment 112992 [details] Patch
Nikolas Zimmermann
Comment 2 2011-10-30 06:48:18 PDT
Comment on attachment 112992 [details] Patch I think this is the wrong direction. We were trying to slowly kill SVGRenderSupport, remember? Why not keep them in RenderSVGModelObject, after-all they are static there?
Note You need to log in before you can comment on or make changes to this bug.