Bug 71170

Summary:

webkit fails to build with Python 3

Product:

WebKit

Reporter:

Robert Marmorstein <robert>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Patch to fix build issue.	none
Fix a style issue with the previous patch	pnormand: review-

Robert Marmorstein

Reported 2011-10-28 19:49:58 PDT

Created attachment 112964 [details] Patch to fix build issue. When I try to build webkit using the build-webkit script, it bails out with a syntax error about exceptions. The problem is that CodeGenerationInspector.py uses some artifacts from Python 2 that aren't supported in Python 3. This is easy to fix -- I will attach a patch.

Attachments
Patch to fix build issue. (1.41 KB, patch) 2011-10-28 19:49 PDT, Robert Marmorstein	no flags	Details Formatted Diff Diff
Fix a style issue with the previous patch (1.41 KB, patch) 2011-10-28 20:03 PDT, Robert Marmorstein	pnormand: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

WebKit Review Bot

Comment 1 2011-10-28 19:53:19 PDT

Attachment 112964 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/inspector/CodeGeneratorInsp..." exit_code: 1 Source/WebCore/inspector/CodeGeneratorInspector.py:37: expected 1 blank line, found 0 [pep8/E301] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.

Robert Marmorstein

Comment 2 2011-10-28 20:03:32 PDT

Created attachment 112965 [details] Fix a style issue with the previous patch Not sure exactly why the style filter was complaining, but hopefully this will fix it.

WebKit Review Bot

Comment 3 2011-10-28 20:05:44 PDT

Attachment 112965 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/inspector/CodeGeneratorInsp..." exit_code: 1 Source/WebCore/inspector/CodeGeneratorInspector.py:37: expected 1 blank line, found 0 [pep8/E301] [5] Total errors found: 1 in 1 files If any of these errors are false positives, please file a bug against check-webkit-style.

Philippe Normand

Comment 4 2011-11-03 08:32:14 PDT

Comment on attachment 112965 [details] Fix a style issue with the previous patch View in context: https://bugs.webkit.org/attachment.cgi?id=112965&action=review > Source/WebCore/inspector/CodeGeneratorInspector.py:60 > +except Exception as e: AFAIK the minimum Python version required by webkitpy is 2.5. This syntax works only in >= 2.6 though.

Eric Seidel (no email)

Comment 5 2011-11-05 16:26:00 PDT

I'm still interested in this patch. But since this current path is r-'d, I'm going to dupe this against an earlier bug on teh same subject. *** This bug has been marked as a duplicate of bug 55037 ***

Note You need to log in before you can comment on or make changes to this bug.