Bug 71166

Summary: Overridden LayoutRect method still uses IntRects
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Emil A Eklund
Reported 2011-10-28 17:50:27 PDT
Some of the virtual functions that return a LayoutRect still have overridden versions that return an IntRect. Specifically the following methods: controlClipRect windowResizerRect windowClipRect visibleContentRect scrollCornerRect outlineBoundsForRepaint localCaretRect
Attachments
Patch (17.03 KB, patch)
2011-10-28 17:57 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-10-28 17:57:50 PDT
Created attachment 112954 [details] Patch
Eric Seidel (no email)
Comment 2 2011-10-28 21:42:15 PDT
Comment on attachment 112954 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112954&action=review > Source/WebCore/page/FrameView.cpp:2312 > -LayoutRect FrameView::windowClipRect(bool clipToContents) const > +IntRect FrameView::windowClipRect(bool clipToContents) const Why going back?
Emil A Eklund
Comment 3 2011-10-31 10:13:15 PDT
(In reply to comment #2) > (From update of attachment 112954 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112954&action=review > > > Source/WebCore/page/FrameView.cpp:2312 > > -LayoutRect FrameView::windowClipRect(bool clipToContents) const > > +IntRect FrameView::windowClipRect(bool clipToContents) const > > Why going back? We're keeping certain things as ints to ensure alignment, specifically window coordinates and sizes as well as scroll offsets.
WebKit Review Bot
Comment 4 2011-10-31 14:33:53 PDT
Comment on attachment 112954 [details] Patch Clearing flags on attachment: 112954 Committed r98883: <http://trac.webkit.org/changeset/98883>
WebKit Review Bot
Comment 5 2011-10-31 14:33:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.