Bug 71154

Summary: webkit.py gdb visualizer is broken after change to StringImpl
Product: WebKit Reporter: Rafael Weinstein <rafaelw>
Component: Tools / TestsAssignee: Rafael Weinstein <rafaelw>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren, msaboff, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rafael Weinstein
Reported 2011-10-28 15:53:18 PDT
StringImpl's m_data is now m_data16. Change webkit.py to match.
Attachments
Patch (1.53 KB, patch)
2011-10-28 15:56 PDT, Rafael Weinstein 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rafael Weinstein
Comment 1 2011-10-28 15:56:56 PDT
Created attachment 112929 [details] Patch
Rafael Weinstein
Comment 2 2011-10-28 15:58:07 PDT
BTW, I've never touched this file before and know almost no python. I'm just guessing that both WTFString & JSCUString need to be changed. Please verify that this is right.
WebKit Review Bot
Comment 3 2011-10-28 17:04:01 PDT
Comment on attachment 112929 [details] Patch Clearing flags on attachment: 112929 Committed r98785: <http://trac.webkit.org/changeset/98785>
WebKit Review Bot
Comment 4 2011-10-28 17:04:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.