Bug 71151 – Rename DataTransferItems to DataTransferItemList

• Component: New Bugs
• Status: RESOLVED FIXED

[Daniel Cheng]

Rename DataTransferItems to DataTransferItemList

[Daniel Cheng]

Created attachment 112922 [details]
Patch

[WebKit Review Bot]

Attachment 112922 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 19 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 112922 [details]
Patch

Attachment 112922 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10244052

[Daniel Cheng]

Created attachment 112931 [details]
Patch

[WebKit Review Bot]

Attachment 112931 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tony Chang]

Comment on attachment 112931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112931&action=review

> Source/WebCore/ChangeLog:4
> +        Rename DataTransferItems to DataTransferItemList
> +        https://bugs.webkit.org/show_bug.cgi?id=71151

Do you have a link to where this rename happened?

[Daniel Cheng]

Created attachment 112937 [details]
Patch

[Daniel Cheng]

Comment on attachment 112931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112931&action=review

>> Source/WebCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=71151
> 
> Do you have a link to where this rename happened?

Added a link to the spec with a little context.

[WebKit Review Bot]

Attachment 112937 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/dom/Clipboard.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 23 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Tony Chang]

Comment on attachment 112937 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112937&action=review

Please make sure that the ews bots all compile before landing.

> Source/WebCore/WebCore.xcodeproj/project.pbxproj:1767
> -		781755861365A1B00093BE2E /* DataTransferItems.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 781755851365A1B00093BE2E /* DataTransferItems.cpp */; };
> +		781755861365A1B00093BE2E /* DataTransferItemList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 781755851365A1B00093BE2E /* DataTransferItemList.cpp */; };

Did you actually open these in xcode?  I think the hash will change because the filename changed . . .

[Daniel Bates]

Comment on attachment 112937 [details]
Patch

Attachment 112937 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/10241309

[Daniel Cheng]

Comment on attachment 112937 [details]
Patch

Patched it into a clean tree on Mac and it worked for me.

[WebKit Review Bot]

Comment on attachment 112937 [details]
Patch

Clearing flags on attachment: 112937

Committed r98821: <http://trac.webkit.org/changeset/98821>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.