Bug 71143 – [Meta] Master bug for sub-pixel layout branch

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Levi Weintraub]

Please file issues found in the http://svn.webkit.org/repository/webkit/branches/subpixellayout branch as blocking issues for this bug.

[Eric Seidel (no email)]

Created attachment 112915 [details]
current diff from the branch

Generated by running:
svn diff --old http://svn.webkit.org/repository/webkit/trunk@98654
--new http://svn.webkit.org/repository/webkit/branches/subpixellayout
Source/

[Eric Seidel (no email)]

It seems like much of the current branch could be landed on trunk as-is.  All the LayoutSize/LayoutPoint changes.  That would make the branch diff smaller and easier to read.

[Emil A Eklund]

Created attachment 113082 [details]
current diff from branch (r98861)

[Emil A Eklund]

Created attachment 114405 [details]
patch

current diff from branch (r99750)

[Emil A Eklund]

Created attachment 115902 [details]
current diff from branch (r100802)

[Emil A Eklund]

Created attachment 121200 [details]
Source diff from branch (r104084)

[Emil A Eklund]

Created attachment 122095 [details]
Source diff from branch (r104725)

[Emil A Eklund]

FYI: The current patch (r104725) builds the mac, linux/qt and linux/chromium ports. It does _not_ include updated test expectations. Those will be uploaded separately.

[Emil A Eklund]

Created attachment 123419 [details]
Source diff from branch (105194)

Source diff from branch against trunk@105194, excluding new data types which have been split out into a separate change (bug 76571).

[Emil A Eklund]

Created attachment 123981 [details]
Source diff from branch (105803)

Source diff from branch against trunk@105803. Again, this patch does not include the new subpixel data types as those are tracked in bug 76571.

[Emil A Eklund]

Created attachment 123987 [details]
Source diff from branch (105803)

[Emil A Eklund]

Created attachment 124651 [details]
Source diff from branch (105803)

[Levi Weintraub]

The test expectations that change, along with links to their new and old expectations, can be found here: http://eae.net/webkit/modified_tests.html

[Eric Seidel (no email)]

Comment on attachment 124651 [details]
Source diff from branch (105803) 

View in context: https://bugs.webkit.org/attachment.cgi?id=124651&action=review

> Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:118
> +    return static_cast<IntRect>(rect);

Seems like many of these rounding changes could/should be done first.  We're not changing types here, you're just making more explicit what's going on, or?

[Emil A Eklund]

Comment on attachment 124651 [details]
Source diff from branch (105803) 

View in context: https://bugs.webkit.org/attachment.cgi?id=124651&action=review

>> Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:118
>> +    return static_cast<IntRect>(rect);
> 
> Seems like many of these rounding changes could/should be done first.  We're not changing types here, you're just making more explicit what's going on, or?

Correct, the reason we cast platform specific types to their webkit equivalent is to avoid ambiguity. There aren't too many places where we do this but if you think it makes sense I'd gladly break those changes out into a separate patch.

[Eric Seidel (no email)]

I just skimmed very briefly and was lookign for non-controvertial things to break out -- changes which had little/nothign to do with the larger goal of moving to fixed point layout.

[Emil A Eklund]

(In reply to comment #16)
> I just skimmed very briefly and was lookign for non-controvertial things to break out -- changes which had little/nothign to do with the larger goal of moving to fixed point layout.

Makes sense, I'll break those changes out. If you have any other suggestions for things to break out I'm all ears!

[Levi Weintraub]

Comment on attachment 124651 [details]
Source diff from branch (105803) 

View in context: https://bugs.webkit.org/attachment.cgi?id=124651&action=review

> Source/WebCore/workers/WorkerContext.cpp:NaN
>  void WorkerContext::webkitRequestFileSys

The diff in this file is the result of a bad merge. It's clearly not part of our patch.

[Levi Weintraub]

Comment on attachment 124651 [details]
Source diff from branch (105803) 

View in context: https://bugs.webkit.org/attachment.cgi?id=124651&action=review

> Source/WebCore/rendering/EllipsisBox.cpp:58
> +    context->drawText(font, RenderBlock::constructTextRun(renderer(), font, m_str, style, TextRun::AllowTrailingExpansion), FloatPoint(x() + paintOffset.x(), y() + paintOffset.y() + style->fontMetrics().ascent()));

This change should also be dropped.

[Emil A Eklund]

Created attachment 126394 [details]
Source diff from branch (107124)

[Emil A Eklund]

Created attachment 128358 [details]
Source diff from branch (108547)

[Emil A Eklund]

Created attachment 129503 [details]
Source diff from branch (109226)

[Emil A Eklund]

Created attachment 132336 [details]
Source diff from branch (110884)

[Emil A Eklund]

Created attachment 132363 [details]
Source diff from branch (111035)

[Emil A Eklund]

Created attachment 132916 [details]
Source diff from branch (111406)

[Gustavo Noronha (kov)]

Comment on attachment 132916 [details]
Source diff from branch (111406)

Attachment 132916 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12034067

[WebKit Review Bot]

Attachment 132916 [details] did not pass style-queue:

Source/WebCore/platform/Length.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/Length.h:112:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/Length.h:116:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:82:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:540:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:542:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:543:  is_specialized is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:552:  is_signed is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:553:  is_integer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:554:  is_exact is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:558:  round_error is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:561:  min_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:562:  min_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:563:  max_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:564:  max_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:566:  has_infinity is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:567:  has_quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:568:  has_signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:569:  has_denorm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:570:  has_denorm_loss is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:574:  quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:576:  signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:578:  denorm_min is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:581:  is_iec559 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:582:  is_bounded is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:583:  is_modulo is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:585:  Should have a space between // and comment  [whitespace/comments] [4]
SFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1
ource/WebCore/platform/FractionalLayoutUnit.h:586:  tinyness_before is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:587:  round_style is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/rendering/RenderView.cpp:302:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Source/WebCore/rendering/RenderTreeAsText.cpp:79:  The parameter name "behavior" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/rendering/RenderView.h:203:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorPageAgent.cpp:54:  "FrameView.h" already included at Source/WebCore/inspector/InspectorPageAgent.cpp:53  [build/include] [4]
Source/WebCore/rendering/LayoutTypes.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 34 in 131 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Early Warning System Bot]

Comment on attachment 132916 [details]
Source diff from branch (111406)

Attachment 132916 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12072016

[Build Bot]

Comment on attachment 132916 [details]
Source diff from branch (111406)

Attachment 132916 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12070037

[WebKit Review Bot]

Comment on attachment 132916 [details]
Source diff from branch (111406)

Attachment 132916 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12086031

[Gyuyoung Kim]

Comment on attachment 132916 [details]
Source diff from branch (111406)

Attachment 132916 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12071047

[Early Warning System Bot]

Comment on attachment 132916 [details]
Source diff from branch (111406)

Attachment 132916 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12090043

[Emil A Eklund]

Created attachment 134163 [details]
Source diff from branch (112277)

[Emil A Eklund]

Created attachment 134182 [details]
Source diff from branch (112329)

[Emil A Eklund]

Created attachment 134914 [details]
Source diff from branch (112729)

[Emil A Eklund]

Created attachment 135154 [details]
Source diff from branch (112900)

[Emil A Eklund]

Created attachment 135372 [details]
Source diff from branch (113044)

[Emil A Eklund]

Created attachment 135700 [details]
Source diff from branch (113241)

[WebKit Review Bot]

Attachment 135700 [details] did not pass style-queue:

Source/WebCore/rendering/LayoutTypes.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/rendering/LayoutTypes.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/rendering/RenderView.h:204:  The parameter name "r" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:543:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:545:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:546:  is_specialized is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:555:  is_signed is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:556:  is_integer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:557:  is_exact is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:561:  round_error is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:564:  min_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:565:  min_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:566:  max_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:567:  max_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:569:  has_infinity is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:570:  has_quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:571:  has_signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:572:  has_denorm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:573:  has_denorm_loss is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:577:  quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:579:  signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:581:  denorm_min is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:584:  is_iec559 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:585:  is_bounded is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:586:  is_modulo is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:588:  Should have a space between // and comment  [whitespaFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1
ce/comments] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:589:  tinyness_before is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:590:  round_style is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/Length.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/Length.h:112:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/Length.h:116:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:79:  The parameter name "behavior" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 33 in 53 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 135700 [details]
Source diff from branch (113241)

Attachment 135700 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12330102

[Build Bot]

Comment on attachment 135700 [details]
Source diff from branch (113241)

Attachment 135700 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12331086

[Build Bot]

Comment on attachment 135700 [details]
Source diff from branch (113241)

Attachment 135700 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12327210

[Early Warning System Bot]

Comment on attachment 135700 [details]
Source diff from branch (113241)

Attachment 135700 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12336007

[Early Warning System Bot]

Comment on attachment 135700 [details]
Source diff from branch (113241)

Attachment 135700 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12339010

[WebKit Review Bot]

Comment on attachment 135700 [details]
Source diff from branch (113241)

Attachment 135700 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12338014

[Gyuyoung Kim]

Comment on attachment 135700 [details]
Source diff from branch (113241)

Attachment 135700 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12337056

[Emil A Eklund]

Created attachment 135898 [details]
Source diff from branch (113337)

[Emil A Eklund]

Created attachment 135960 [details]
Source diff from branch (113337)

[Emil A Eklund]

Created attachment 136239 [details]
Source diff from branch (113577)

[WebKit Review Bot]

Attachment 136239 [details] did not pass style-queue:

Source/WebCore/rendering/LayoutTypes.h:39:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/rendering/LayoutTypes.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:81:  wtf_ceil is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:538:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:540:  This { should be at the end of the previous line  [whitespace/braces] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:541:  is_specialized is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:550:  is_signed is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:551:  is_integer is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:552:  is_exact is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:556:  round_error is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:559:  min_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:560:  min_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:561:  max_exponent is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:562:  max_exponent10 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:564:  has_infinity is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:565:  has_quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:566:  has_signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:567:  has_denorm is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:568:  has_denorm_loss is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:572:  quiet_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:574:  signaling_NaN is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:576:  denorm_min is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:579:  is_iec559 is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:580:  is_bounded is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:581:  is_modulo is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:583:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:584:  tinyness_before is incorrectly named. Don't use underscores in your identifieFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1
r names.  [readability/naming] [4]
Source/WebCore/platform/FractionalLayoutUnit.h:585:  round_style is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/Length.h:33:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/platform/Length.h:112:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/platform/Length.h:116:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:79:  The parameter name "behavior" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 32 in 46 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 136239 [details]
Source diff from branch (113577)

Attachment 136239 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12370282

[Early Warning System Bot]

Comment on attachment 136239 [details]
Source diff from branch (113577)

Attachment 136239 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12373270

[Early Warning System Bot]

Comment on attachment 136239 [details]
Source diff from branch (113577)

Attachment 136239 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12370298

[Gustavo Noronha (kov)]

Comment on attachment 136239 [details]
Source diff from branch (113577)

Attachment 136239 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12371299

[Emil A Eklund]

Created attachment 136500 [details]
Source diff from branch (113730)

[WebKit Review Bot]

Attachment 136500 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/WebCore.exp.in', u'Source/W..." exit_code: 1
Source/WebCore/rendering/LayoutTypes.h:40:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/rendering/RenderTreeAsText.cpp:79:  The parameter name "behavior" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Philippe Normand]

Comment on attachment 136500 [details]
Source diff from branch (113730)

Attachment 136500 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12381415

[Early Warning System Bot]

Comment on attachment 136500 [details]
Source diff from branch (113730)

Attachment 136500 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12383363

[Early Warning System Bot]

Comment on attachment 136500 [details]
Source diff from branch (113730)

Attachment 136500 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12385212

[Build Bot]

Comment on attachment 136500 [details]
Source diff from branch (113730)

Attachment 136500 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12379590

[Gyuyoung Kim]

Comment on attachment 136500 [details]
Source diff from branch (113730)

Attachment 136500 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12383397

[Emil A Eklund]

Created attachment 136530 [details]
Source diff from branch (113730)

[Gustavo Noronha (kov)]

Comment on attachment 136530 [details]
Source diff from branch (113730) 

Attachment 136530 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12380488

[Early Warning System Bot]

Comment on attachment 136530 [details]
Source diff from branch (113730) 

Attachment 136530 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12384411

[Early Warning System Bot]

Comment on attachment 136530 [details]
Source diff from branch (113730) 

Attachment 136530 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12383433

[Emil A Eklund]

Created attachment 137098 [details]
Source diff from branch (114126)

[Gustavo Noronha (kov)]

Comment on attachment 137098 [details]
Source diff from branch (114126)

Attachment 137098 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12393924

[Early Warning System Bot]

Comment on attachment 137098 [details]
Source diff from branch (114126)

Attachment 137098 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12403029

[Early Warning System Bot]

Comment on attachment 137098 [details]
Source diff from branch (114126)

Attachment 137098 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12396767

[Build Bot]

Comment on attachment 137098 [details]
Source diff from branch (114126)

Attachment 137098 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12395860

[Gyuyoung Kim]

Comment on attachment 137098 [details]
Source diff from branch (114126)

Attachment 137098 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12400121

[WebKit Review Bot]

Comment on attachment 137098 [details]
Source diff from branch (114126)

Attachment 137098 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12399398

New failing tests:
compositing/geometry/abs-position-inside-opacity.html
compositing/geometry/fixed-in-composited.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
compositing/direct-image-compositing.html
animations/additive-transform-animations.html
accessibility/aria-disabled.html
compositing/text-on-large-layer.html
compositing/layers-inside-overflow-scroll.html
compositing/animation/state-at-end-event-transform-layer.html
compositing/sibling-positioning.html
compositing/generated-content.html
compositing/self-painting-layers.html
animations/cross-fade-webkit-mask-box-image.html
animations/animation-hit-test-transform.html
WebFrameTest.FAILS_DivAutoZoomParamsTest
animations/3d/change-transform-in-end-event.html
animations/missing-values-last-keyframe.html
animations/cross-fade-list-style-image.html
animations/missing-values-first-keyframe.html
compositing/geometry/fixed-position-composited-page-scale.html
animations/cross-fade-background-image.html
compositing/geometry/clipping-foreground.html
animations/cross-fade-border-image-source.html
compositing/geometry/composited-html-size.html
compositing/compositing-visible-descendant.html
animations/cross-fade-webkit-mask-image.html
compositing/iframes/composited-iframe-alignment.html
compositing/color-matching/image-color-matching.html
animations/state-at-end-event.html
compositing/color-matching/pdf-image-match.html

[WebKit Review Bot]

Created attachment 137115 [details]
Archive of layout-test-results from ec2-cr-linux-04

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-04  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Emil A Eklund]

Created attachment 137367 [details]
Source diff from branch (114265)

[Emil A Eklund]

Created attachment 137763 [details]
Source diff from branch (114550)

[Emil A Eklund]

Created attachment 138119 [details]
Source diff from branch (114758)

[Build Bot]

Comment on attachment 138119 [details]
Source diff from branch (114758)

Attachment 138119 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12480204

[WebKit Review Bot]

Comment on attachment 138119 [details]
Source diff from branch (114758)

Attachment 138119 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12477241

[Emil A Eklund]

Created attachment 138382 [details]
Source diff from branch (114777)

[Eric Seidel (no email)]

Comment on attachment 138382 [details]
Source diff from branch (114777)

View in context: https://bugs.webkit.org/attachment.cgi?id=138382&action=review

Honestly this seems fine.   You reach a point where it will be more efficient to move testing onto the build bots instead of the EWS bots. :)

> Source/WebCore/rendering/LayoutTypes.h:84
> +    return LayoutPoint(p.x(), p.y());

Why is this one LayoutPoint and the one above it FractionalLayoutPoint?

> Source/WebCore/rendering/RenderTreeAsText.cpp:110
> +    // FIXME: These should be printed as floats. Keeping them ints for consistency with pervious test expectations.
> +    return ts << "(" << p.x().toInt() << "," << p.y().toInt() << ")";

Ah, you have joined a long tradition here. :)

> Source/WebCore/rendering/RenderTreeAsText.cpp:279
> +    // FIXME: Convert layout test results to report sub-pixel values, in the meantime using enclosingIntRect
> +    // for consistency with old results. This doesn't apply to tables, which are still laid out on integer bounds.

WE need to come up with a list of htese and do them all at once some day. :)

> Source/WebCore/rendering/PaintInfo.h:101
> -    static IntRect infiniteRect() { return IntRect(INT_MIN / 2, INT_MIN / 2, INT_MAX, INT_MAX); }
> +    static IntRect infiniteRect() { return IntRect(LayoutRect::infiniteRect()); }

This seems odd.  I guess it makes sense for this to be based on LayoutRect?  And if so why not call toInt()?  (Or maybe that doesn't exist).

[Build Bot]

Comment on attachment 138382 [details]
Source diff from branch (114777)

Attachment 138382 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12479841

[Gustavo Noronha (kov)]

Comment on attachment 138382 [details]
Source diff from branch (114777)

Attachment 138382 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12474908

[Early Warning System Bot]

Comment on attachment 138382 [details]
Source diff from branch (114777)

Attachment 138382 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12512172

[Early Warning System Bot]

Comment on attachment 138382 [details]
Source diff from branch (114777)

Attachment 138382 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12515054

[Emil A Eklund]

Created attachment 138435 [details]
Source diff from branch (114938)

[Philippe Normand]

Comment on attachment 138435 [details]
Source diff from branch (114938)

Attachment 138435 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/12524050

[Emil A Eklund]

Created attachment 139026 [details]
Source diff from branch (114938 mkII)

[Emil A Eklund]

Created attachment 139495 [details]
Source diff from branch (115647)

[Early Warning System Bot]

Comment on attachment 139495 [details]
Source diff from branch (115647)

Attachment 139495 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12593311

[WebKit Review Bot]

Comment on attachment 139495 [details]
Source diff from branch (115647)

Attachment 139495 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12581426

[Emil A Eklund]

Created attachment 139549 [details]
Source diff from branch (115687)

[Emil A Eklund]

Created attachment 139645 [details]
Source diff from branch (115722)

[Gyuyoung Kim]

Comment on attachment 139645 [details]
Source diff from branch (115722)

Attachment 139645 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12581719

[WebKit Review Bot]

Comment on attachment 139645 [details]
Source diff from branch (115722)

Attachment 139645 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12587610

[Early Warning System Bot]

Comment on attachment 139645 [details]
Source diff from branch (115722)

Attachment 139645 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12589602

[Emil A Eklund]

Created attachment 139663 [details]
Source diff from branch (115741)

[WebKit Review Bot]

Please wait for approval from [e-mail], [e-mail], [e-mail], [e-mail] or [e-mail] before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.

[WebKit Review Bot]

Comment on attachment 139663 [details]
Source diff from branch (115741)

Attachment 139663 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12592634

[Gyuyoung Kim]

Comment on attachment 139663 [details]
Source diff from branch (115741)

Attachment 139663 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12595582

[Early Warning System Bot]

Comment on attachment 139663 [details]
Source diff from branch (115741)

Attachment 139663 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12597513

[Early Warning System Bot]

Comment on attachment 139663 [details]
Source diff from branch (115741)

Attachment 139663 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12591662

[Emil A Eklund]

Created attachment 139695 [details]
Source diff from branch (115741 mkII)

[Build Bot]

Comment on attachment 139695 [details]
Source diff from branch (115741 mkII)

Attachment 139695 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12593675

[WebKit Review Bot]

Comment on attachment 139695 [details]
Source diff from branch (115741 mkII)

Attachment 139695 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12585733

[Gyuyoung Kim]

Comment on attachment 139695 [details]
Source diff from branch (115741 mkII)

Attachment 139695 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/12598515

[Early Warning System Bot]

Comment on attachment 139695 [details]
Source diff from branch (115741 mkII)

Attachment 139695 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12585746

[Emil A Eklund]

Created attachment 139716 [details]
Source diff from branch (115741 mkIII)

[WebKit Review Bot]

Comment on attachment 139716 [details]
Source diff from branch (115741 mkIII)

Attachment 139716 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12597575

[Build Bot]

Comment on attachment 139716 [details]
Source diff from branch (115741 mkIII)

Attachment 139716 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12586755

[Early Warning System Bot]

Comment on attachment 139716 [details]
Source diff from branch (115741 mkIII)

Attachment 139716 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12595657

[Build Bot]

Comment on attachment 139716 [details]
Source diff from branch (115741 mkIII)

Attachment 139716 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12584745

[Early Warning System Bot]

Comment on attachment 139716 [details]
Source diff from branch (115741 mkIII)

Attachment 139716 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12586770

[Emil A Eklund]

Created attachment 139734 [details]
Source diff from branch (115741 mkIV)

[Emil A Eklund]

Created attachment 139740 [details]
Source diff from branch (115787)

[Emil A Eklund]

Created attachment 139742 [details]
Source diff from branch (115787 mkII)

Argh

[Emil A Eklund]

Created attachment 139744 [details]
Source diff from branch (115787 mkIII)

[Early Warning System Bot]

Comment on attachment 139744 [details]
Source diff from branch (115787 mkIII)

Attachment 139744 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12588750

[Early Warning System Bot]

Comment on attachment 139744 [details]
Source diff from branch (115787 mkIII)

Attachment 139744 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/12585809

[WebKit Review Bot]

Comment on attachment 139744 [details]
Source diff from branch (115787 mkIII)

Attachment 139744 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12584790

[Build Bot]

Comment on attachment 139744 [details]
Source diff from branch (115787 mkIII)

Attachment 139744 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12585808

[Build Bot]

Comment on attachment 139744 [details]
Source diff from branch (115787 mkIII)

Attachment 139744 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/12590770

[Emil A Eklund]

Created attachment 139831 [details]
Source diff from branch (115787 mkIV)

[Early Warning System Bot]

Comment on attachment 139831 [details]
Source diff from branch (115787 mkIV)

Attachment 139831 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/12587890

[Emil A Eklund]

Created attachment 139838 [details]
Source diff from branch (115787 mkV)

[WebKit Review Bot]

Comment on attachment 139838 [details]
Source diff from branch (115787 mkV)

Attachment 139838 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/12607010

New failing tests:
compositing/geometry/abs-position-inside-opacity.html
compositing/geometry/fixed-in-composited.html
animations/3d/matrix-transform-type-animation.html
animations/3d/state-at-end-event-transform.html
compositing/direct-image-compositing.html
compositing/geometry/fixed-position-transform-composited-page-scale-down.html
animations/additive-transform-animations.html
accessibility/aria-disabled.html
compositing/text-on-large-layer.html
compositing/layers-inside-overflow-scroll.html
compositing/animation/state-at-end-event-transform-layer.html
compositing/sibling-positioning.html
compositing/geometry/fixed-position-iframe-composited-page-scale.html
compositing/generated-content.html
compositing/self-painting-layers.html
animations/cross-fade-webkit-mask-box-image.html
animations/3d/change-transform-in-end-event.html
animations/missing-values-last-keyframe.html
animations/cross-fade-list-style-image.html
animations/missing-values-first-keyframe.html
compositing/geometry/fixed-position-composited-page-scale.html
animations/cross-fade-background-image.html
compositing/geometry/clipping-foreground.html
animations/cross-fade-border-image-source.html
compositing/geometry/composited-html-size.html
compositing/compositing-visible-descendant.html
animations/cross-fade-webkit-mask-image.html
compositing/iframes/composited-iframe-alignment.html
compositing/color-matching/image-color-matching.html
compositing/color-matching/pdf-image-match.html

[WebKit Review Bot]

Created attachment 139850 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Levi Weintraub]

Ding dong the branch is dead.  http://trac.webkit.org/changeset/119501 moved it from branches/subpixellayout to branches/old/subpixellayout.