Bug 71132

Summary: IndexedDB: Remove null key support (part 2)
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, fishd, hans, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2011-10-28 12:05:06 PDT
IndexedDB: Remove null key support (part 2)
Attachments
Patch (3.93 KB, patch)
2011-10-28 12:36 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (3.79 KB, patch)
2011-10-31 09:43 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2011-10-28 12:36:16 PDT
Created attachment 112896 [details] Patch
WebKit Review Bot
Comment 2 2011-10-28 12:39:35 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3 2011-10-30 22:57:20 PDT
Comment on attachment 112896 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112896&action=review OK, R=me. Will > Source/WebKit/chromium/ChangeLog:8 > + Part 2 of a two-sided commit. Remove IDBKey::NullType now that nit: this kind of detail about the mechanics of landing this patch probably don't need to be in the ChangeLog. i would just type this as a comment in the bug.
Joshua Bell
Comment 4 2011-10-31 09:17:08 PDT
Part one was: https://bugs.webkit.org/show_bug.cgi?id=70065
Joshua Bell
Comment 5 2011-10-31 09:43:19 PDT
Created attachment 113060 [details] Patch
WebKit Review Bot
Comment 6 2011-10-31 16:09:57 PDT
Comment on attachment 113060 [details] Patch Clearing flags on attachment: 113060 Committed r98900: <http://trac.webkit.org/changeset/98900>
WebKit Review Bot
Comment 7 2011-10-31 16:10:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.