Bug 71132 - IndexedDB: Remove null key support (part 2)
Summary: IndexedDB: Remove null key support (part 2)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joshua Bell
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 12:05 PDT by Joshua Bell
Modified: 2011-10-31 16:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.93 KB, patch)
2011-10-28 12:36 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Patch (3.79 KB, patch)
2011-10-31 09:43 PDT, Joshua Bell 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joshua Bell 2011-10-28 12:05:06 PDT 
IndexedDB: Remove null key support (part 2)
Comment 1 Joshua Bell 2011-10-28 12:36:16 PDT 
Created attachment 112896 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-28 12:39:35 PDT 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 Darin Fisher (:fishd, Google) 2011-10-30 22:57:20 PDT 
Comment on attachment 112896 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112896&action=review

OK, R=me.  Will

> Source/WebKit/chromium/ChangeLog:8
> +        Part 2 of a two-sided commit. Remove IDBKey::NullType now that

nit: this kind of detail about the mechanics of landing this patch probably
don't need to be in the ChangeLog.  i would just type this as a comment in the
bug.
Comment 4 Joshua Bell 2011-10-31 09:17:08 PDT 
Part one was: https://bugs.webkit.org/show_bug.cgi?id=70065
Comment 5 Joshua Bell 2011-10-31 09:43:19 PDT 
Created attachment 113060 [details]
Patch
Comment 6 WebKit Review Bot 2011-10-31 16:09:57 PDT 
Comment on attachment 113060 [details]
Patch

Clearing flags on attachment: 113060

Committed r98900: <http://trac.webkit.org/changeset/98900>
Comment 7 WebKit Review Bot 2011-10-31 16:10:02 PDT 
All reviewed patches have been landed.  Closing bug.