Bug 71129

Summary: IndexedDB: IDBDatabase should have a close pending field.
Product: WebKit Reporter: jochen
Component: WebCore Misc.Assignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, dgrogan, hans, jsbell, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

jochen
Reported 2011-10-28 12:01:47 PDT
IDBDatabase should have a close pending field, and nobody should send versionchange events to it while it's closing (see also http://code.google.com/p/chromium/issues/detail?id=100645)
Attachments
Patch (15.55 KB, patch)
2012-06-28 11:17 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2012-06-28 11:17:48 PDT
Created attachment 149976 [details] Patch
Joshua Bell
Comment 2 2012-06-28 11:18:57 PDT
alecflett@ - can you take a look? tony@ - r?
Joshua Bell
Comment 3 2012-06-28 11:27:04 PDT
Note that most chunks of the new layout test passed before and are redundant with other tests, but I wanted everything that exercised the flag in one place. The bits that previously failed were the version change and delete, which exercise the case described in the ChangeLog.
Alec Flett
Comment 4 2012-06-28 15:47:32 PDT
Comment on attachment 149976 [details] Patch LGTM
WebKit Review Bot
Comment 5 2012-06-28 16:48:49 PDT
Comment on attachment 149976 [details] Patch Clearing flags on attachment: 149976 Committed r121488: <http://trac.webkit.org/changeset/121488>
WebKit Review Bot
Comment 6 2012-06-28 16:48:54 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.