| Summary: | Update XMLHttpRequest.send idl declaration to match implementation. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||
| Component: | DOM | Assignee: | Pavel Podivilov <podivilov> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, ojan, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Podivilov
2011-10-28 08:44:38 PDT
Created attachment 112870 [details]
Patch
Comment on attachment 112870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112870&action=review > Source/WebCore/xml/XMLHttpRequest.idl:79 > + [Custom] void send(in Blob data) > + raises(DOMException); Will it break when Blob is disabled? Comment on attachment 112870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112870&action=review >> Source/WebCore/xml/XMLHttpRequest.idl:79 >> + [Custom] void send(in Blob data) >> + raises(DOMException); > > Will it break when Blob is disabled? Please add a conditional for BLOB. Created attachment 113025 [details]
Patch
Comment on attachment 113025 [details] Patch Rejecting attachment 113025 [details] from commit-queue. New failing tests: fast/text/atsui-multiple-renderers.html fast/text/international/danda-space.html Full output: http://queues.webkit.org/results/10237973 Comment on attachment 113025 [details] Patch Clearing flags on attachment: 113025 Committed r98893: <http://trac.webkit.org/changeset/98893> All reviewed patches have been landed. Closing bug. |