Bug 71121

Summary: Update XMLHttpRequest.send idl declaration to match implementation.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: DOMAssignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Pavel Podivilov
Reported 2011-10-28 08:44:38 PDT
Update XMLHttpRequest.send idl declaration to match implementation.
Attachments
Patch (1.60 KB, patch)
2011-10-28 08:51 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2011-10-31 02:23 PDT, Pavel Podivilov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-10-28 08:51:10 PDT
Created attachment 112870 [details] Patch
Alexey Proskuryakov
Comment 2 2011-10-28 11:00:32 PDT
Comment on attachment 112870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112870&action=review > Source/WebCore/xml/XMLHttpRequest.idl:79 > + [Custom] void send(in Blob data) > + raises(DOMException); Will it break when Blob is disabled?
Adam Barth
Comment 3 2011-10-28 11:02:56 PDT
Comment on attachment 112870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112870&action=review >> Source/WebCore/xml/XMLHttpRequest.idl:79 >> + [Custom] void send(in Blob data) >> + raises(DOMException); > > Will it break when Blob is disabled? Please add a conditional for BLOB.
Pavel Podivilov
Comment 4 2011-10-31 02:23:43 PDT
Created attachment 113025 [details] Patch
WebKit Review Bot
Comment 5 2011-10-31 09:51:23 PDT
Comment on attachment 113025 [details] Patch Rejecting attachment 113025 [details] from commit-queue. New failing tests: fast/text/atsui-multiple-renderers.html fast/text/international/danda-space.html Full output: http://queues.webkit.org/results/10237973
WebKit Review Bot
Comment 6 2011-10-31 15:53:15 PDT
Comment on attachment 113025 [details] Patch Clearing flags on attachment: 113025 Committed r98893: <http://trac.webkit.org/changeset/98893>
WebKit Review Bot
Comment 7 2011-10-31 15:53:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.