Bug 71121 - Update XMLHttpRequest.send idl declaration to match implementation.
Summary: Update XMLHttpRequest.send idl declaration to match implementation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-28 08:44 PDT by Pavel Podivilov
Modified: 2011-10-31 15:53 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2011-10-28 08:51 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2011-10-31 02:23 PDT, Pavel Podivilov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-10-28 08:44:38 PDT
Update XMLHttpRequest.send idl declaration to match implementation.
Comment 1 Pavel Podivilov 2011-10-28 08:51:10 PDT
Created attachment 112870 [details]
Patch
Comment 2 Alexey Proskuryakov 2011-10-28 11:00:32 PDT
Comment on attachment 112870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112870&action=review

> Source/WebCore/xml/XMLHttpRequest.idl:79
> +        [Custom] void send(in Blob data)
> +            raises(DOMException);

Will it break when Blob is disabled?
Comment 3 Adam Barth 2011-10-28 11:02:56 PDT
Comment on attachment 112870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112870&action=review

>> Source/WebCore/xml/XMLHttpRequest.idl:79
>> +        [Custom] void send(in Blob data)
>> +            raises(DOMException);
> 
> Will it break when Blob is disabled?

Please add a conditional for BLOB.
Comment 4 Pavel Podivilov 2011-10-31 02:23:43 PDT
Created attachment 113025 [details]
Patch
Comment 5 WebKit Review Bot 2011-10-31 09:51:23 PDT
Comment on attachment 113025 [details]
Patch

Rejecting attachment 113025 [details] from commit-queue.

New failing tests:
fast/text/atsui-multiple-renderers.html
fast/text/international/danda-space.html
Full output: http://queues.webkit.org/results/10237973
Comment 6 WebKit Review Bot 2011-10-31 15:53:15 PDT
Comment on attachment 113025 [details]
Patch

Clearing flags on attachment: 113025

Committed r98893: <http://trac.webkit.org/changeset/98893>
Comment 7 WebKit Review Bot 2011-10-31 15:53:21 PDT
All reviewed patches have been landed.  Closing bug.