Bug 71089

Summary: Web Inspector: Support using a different front-end in WebKit2
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, apavlov, bweinstein, joepeck, peter, pfeldman, sam, timothy
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Change
sam: review-, timothy: commit-queue-
Proposed Change (round 2) sam: review+, timothy: commit-queue-

Timothy Hatcher
Reported 2011-10-27 19:37:15 PDT
We need the ability to load a different front-end for debugging/testing purposes. <rdar://problem/10318665>
Attachments
Proposed Change (18.97 KB, patch)
2011-10-27 20:10 PDT, Timothy Hatcher 		sam: review-
timothy: commit-queue-
DetailsFormatted DiffDiff
Proposed Change (round 2) (18.94 KB, patch)
2011-10-28 11:47 PDT, Timothy Hatcher 		sam: review+
timothy: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2011-10-27 20:10:15 PDT
Created attachment 112810 [details] Proposed Change
Sam Weinig
Comment 2 2011-10-28 10:12:19 PDT
Comment on attachment 112810 [details] Proposed Change View in context: https://bugs.webkit.org/attachment.cgi?id=112810&action=review The patch looks ok, but we have been trying to avoid global state, so I think it would be better for these settings to go on the WKContextRef. > Source/WebKit2/UIProcess/API/C/mac/WKInspectorMac.h:39 > +WK_EXPORT void WKInspectorSetCustomBasePath(WKStringRef); > +WK_EXPORT void WKInspectorSetCustomPagePath(WKStringRef); > +WK_EXPORT void WKInspectorSetCustomLocalizedStringsPath(WKStringRef); We usually add parameter names in API headers. These should probably also be per-WKContextRef, not global as they currently are.
Timothy Hatcher
Comment 3 2011-10-28 11:47:36 PDT
Created attachment 112888 [details] Proposed Change (round 2)
Timothy Hatcher
Comment 4 2011-10-28 13:52:32 PDT
Committed r98759
Note You need to log in before you can comment on or make changes to this bug.