Bug 71086

Summary:

Rename a couple of NetscapePlugin and PluginProxy member variables

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, mrobinson, ossy, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+, gustavo: commit-queue-

Anders Carlsson

Reported 2011-10-27 17:40:26 PDT

Rename a couple of NetscapePlugin and PluginProxy member variables

Attachments
Patch (18.51 KB, patch) 2011-10-27 17:41 PDT, Anders Carlsson	sam: review+ gustavo: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2011-10-27 17:41:04 PDT

Created attachment 112789 [details] Patch

Gustavo Noronha (kov)

Comment 2 2011-10-27 23:09:06 PDT

Comment on attachment 112789 [details] Patch Attachment 112789 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10231568

Anders Carlsson

Comment 3 2011-10-31 13:22:31 PDT

Committed r98873: <http://trac.webkit.org/changeset/98873>

Csaba Osztrogonác

Comment 4 2011-10-31 15:59:49 PDT

It broke the GTK build: (as EWS noticed you before landing ...) CXX Source/WebKit2/WebProcess/Plugins/Netscape/x11/Programs_WebKitPluginProcess-NetscapePluginX11.o ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘void WebKit::NetscapePlugin::platformGeometryDidChange()’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:216:9: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:221:57: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘void WebKit::NetscapePlugin::platformPaint(WebCore::GraphicsContext*, const WebCore::IntRect&, bool)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:262:27: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleMouseEvent(const WebKit::WebMouseEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:417:46: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleWheelEvent(const WebKit::WebWheelEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:458:57: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleMouseEnterEvent(const WebKit::WebMouseEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:485:44: error: ‘m_frameRect’ was not declared in this scope ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleMouseLeaveEvent(const WebKit::WebMouseEvent&)’: ../../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:497:44: error: ‘m_frameRect’ was not declared in this scope make[1]: *** [Source/WebKit2/WebProcess/Plugins/Netscape/x11/Programs_WebKitPluginProcess-NetscapePluginX11.o] Error 1 make[1]: Leaving directory `/var/lib/buildbot/build/gtk-linux-32-release/build/WebKitBuild/Release' make: *** [all] Error 2 Could you fix the build please?

Anders Carlsson

Comment 5 2011-10-31 16:07:34 PDT

Sorry, I'll fix it. I had forgotten to save my changes to NetscapePluginX11.cpp

Csaba Osztrogonác

Comment 6 2011-11-02 00:46:53 PDT

(In reply to comment #5) > Sorry, I'll fix it. I had forgotten to save my changes to NetscapePluginX11.cpp Fix landed in http://trac.webkit.org/changeset/98898

Note You need to log in before you can comment on or make changes to this bug.