Bug 71078

Summary: [chromium] Track wheel event handler registration and pass to input filter
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: enne, fishd, jamesr, kbr, nduca, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kbr: review+

James Robinson
Reported 2011-10-27 16:28:00 PDT
[chromium] Track wheel event handler registration and pass to input filter
Attachments
Patch (12.36 KB, patch)
2011-10-27 16:30 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (12.37 KB, patch)
2011-10-27 17:29 PDT, James Robinson 		kbr: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-10-27 16:30:38 PDT
Created attachment 112779 [details] Patch
James Robinson
Comment 2 2011-10-27 16:31:48 PDT
This should make it much easier to test compositor threading things. This patch changes the behavior when --enable-threaded-compositing is passed in, but that's not yet a supported configuration.
Vangelis Kokkevis
Comment 3 2011-10-27 17:21:45 PDT
Comment on attachment 112779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112779&action=review Looks good > Source/WebKit/chromium/src/WebViewImpl.cpp:786 > + m_haveWheelEventHandlers = numberOfWheelHandlers; Is this WebKit style? I would find something like: m_haveWheelEventHandlers = (numberOfWheelHandlers > 0) a bit easier to read.
James Robinson
Comment 4 2011-10-27 17:24:41 PDT
WK style is to avoid comparisons to 0 generally, but I agree that it'd be nice to call out the int->bool conversion here. Will change.
James Robinson
Comment 5 2011-10-27 17:29:08 PDT
Created attachment 112787 [details] Patch
Kenneth Russell
Comment 6 2011-10-28 10:20:38 PDT
Comment on attachment 112787 [details] Patch Looks fine. r=me
James Robinson
Comment 7 2011-10-28 16:30:17 PDT
Committed r98778: <http://trac.webkit.org/changeset/98778>
Note You need to log in before you can comment on or make changes to this bug.