Bug 71046

Summary: Overridden clippedOverflowRectForRepaint() still uses IntRects
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Emil A Eklund <eae>
Status: RESOLVED FIXED    
Severity: Normal CC: eae, leviw, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2011-10-27 11:59:51 PDT
c.f. IntRect RenderReplaced::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const and LayoutRect RenderBox::clippedOverflowRectForRepaint(RenderBoxModelObject* repaintContainer) const
Attachments
Patch (11.01 KB, patch)
2011-10-28 13:37 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-10-28 12:51:09 PDT
Was this intentional? It's really confusing to have virtual methods with apparently different signatures.
Emil A Eklund
Comment 2 2011-10-28 13:08:43 PDT
No, it's not intentional. Thanks for pointing it out! I'll take care of it.
Emil A Eklund
Comment 3 2011-10-28 13:37:40 PDT
Created attachment 112903 [details] Patch
Simon Fraser (smfr)
Comment 4 2011-10-28 13:40:47 PDT
Comment on attachment 112903 [details] Patch Are there other methods that have the same issue?
Emil A Eklund
Comment 5 2011-10-28 13:44:30 PDT
> Are there other methods that have the same issue? There might be, I'm looking into that now and will make sure to fix any occurrences I can find. Thanks again for bringing this to my attention.
WebKit Review Bot
Comment 6 2011-10-28 14:55:27 PDT
Comment on attachment 112903 [details] Patch Clearing flags on attachment: 112903 Committed r98767: <http://trac.webkit.org/changeset/98767>
WebKit Review Bot
Comment 7 2011-10-28 14:55:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.