Bug 71026

Summary: Tighten font change conditions in matched declaration cache
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED CONFIGURATION CHANGED    
Severity: Normal CC: bfulgham, eric, macpherson, ossy, rniwa, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 71186    
Bug Blocks:    
Attachments:
Description Flags
patch none

Description Antti Koivisto 2011-10-27 09:28:23 PDT 
We currently test if font description has changed to see if all properties need to be applied. However only a few size related metrics can actually affect other properties. We can just test those, making the cache somewhat more effective while also making the test faster.
Comment 1 Antti Koivisto 2011-10-27 09:37:53 PDT 
Created attachment 112694 [details]
patch
Comment 2 Antti Koivisto 2011-10-29 02:36:41 PDT 
http://trac.webkit.org/changeset/98803
Comment 3 Csaba Osztrogonác 2011-10-29 10:37:58 PDT 
It made all tests assert on Qt in debug mode:

ASSERTION FAILED: fontCache()->generation() == m_generation
../../../Source/WebCore/platform/graphics/FontFallbackList.cpp(104) : const WebCore::FontData* WebCore::FontFallbackList::fontDataAt(const WebCore::Font*, unsigned int) const

Could you check it, please?
Comment 4 Ryosuke Niwa 2011-10-29 14:18:33 PDT 
It appears that this patch broke 500+ tests on Windows:
http://build.webkit.org/builders/Windows%207%20Release%20%28Tests%29/builds/17418
Comment 5 Antti Koivisto 2011-10-30 09:06:12 PDT 
Rolled out in http://trac.webkit.org/changeset/98826, don't know yet why this would fail only on some platforms.
Comment 6 Eric Seidel (no email) 2011-12-21 14:34:33 PST 
Attachment 112694 [details] was posted by a committer and has review+, assigning to Antti Koivisto for commit.
Comment 7 Brent Fulgham 2022-08-02 13:25:44 PDT 
This path doesn't seem relevant after the updated CSS parser.
Comment 8 Radar WebKit Bug Importer 2022-08-02 13:26:18 PDT 
<rdar://problem/98005179>