Bug 70999

Summary: [Qt] MiniBrowser needs a -window-size option
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: Tools / TestsAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, webkit.review.bot, zeno
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
hausmann: review+, webkit.review.bot: commit-queue-
Patch none

Kenneth Rohde Christiansen
Reported 2011-10-27 01:59:00 PDT
SSIA
Attachments
Patch (7.19 KB, patch)
2011-10-27 02:00 PDT, Kenneth Rohde Christiansen 		hausmann: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (5.56 KB, patch)
2011-10-28 04:09 PDT, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2011-10-27 02:00:56 PDT
Created attachment 112652 [details] Patch
Simon Hausmann
Comment 2 2011-10-27 02:05:37 PDT
Comment on attachment 112652 [details] Patch r=me
WebKit Review Bot
Comment 3 2011-10-27 08:07:17 PDT
Comment on attachment 112652 [details] Patch Rejecting attachment 112652 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: on.cpp.rej patching file Tools/MiniBrowser/qt/MiniBrowserApplication.h patching file Tools/MiniBrowser/qt/utils.cpp Hunk #1 FAILED at 28. 1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/utils.cpp.rej patching file Tools/MiniBrowser/qt/utils.h Hunk #1 FAILED at 42. 1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/utils.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Hausmann', u'--f..." exit_code: 1 Full output: http://queues.webkit.org/results/10227568
Kenneth Rohde Christiansen
Comment 4 2011-10-28 04:09:01 PDT
Created attachment 112845 [details] Patch
WebKit Review Bot
Comment 5 2011-10-28 05:20:28 PDT
Comment on attachment 112845 [details] Patch Clearing flags on attachment: 112845 Committed r98718: <http://trac.webkit.org/changeset/98718>
WebKit Review Bot
Comment 6 2011-10-28 05:20:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.