Bug 70999 - [Qt] MiniBrowser needs a -window-size option
Summary: [Qt] MiniBrowser needs a -window-size option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Rohde Christiansen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-27 01:59 PDT by Kenneth Rohde Christiansen
Modified: 2011-10-28 05:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.19 KB, patch)
2011-10-27 02:00 PDT, Kenneth Rohde Christiansen
hausmann: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (5.56 KB, patch)
2011-10-28 04:09 PDT, Kenneth Rohde Christiansen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2011-10-27 01:59:00 PDT
SSIA
Comment 1 Kenneth Rohde Christiansen 2011-10-27 02:00:56 PDT
Created attachment 112652 [details]
Patch
Comment 2 Simon Hausmann 2011-10-27 02:05:37 PDT
Comment on attachment 112652 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2011-10-27 08:07:17 PDT
Comment on attachment 112652 [details]
Patch

Rejecting attachment 112652 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
on.cpp.rej
patching file Tools/MiniBrowser/qt/MiniBrowserApplication.h
patching file Tools/MiniBrowser/qt/utils.cpp
Hunk #1 FAILED at 28.
1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/utils.cpp.rej
patching file Tools/MiniBrowser/qt/utils.h
Hunk #1 FAILED at 42.
1 out of 1 hunk FAILED -- saving rejects to file Tools/MiniBrowser/qt/utils.h.rej

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Simon Hausmann', u'--f..." exit_code: 1

Full output: http://queues.webkit.org/results/10227568
Comment 4 Kenneth Rohde Christiansen 2011-10-28 04:09:01 PDT
Created attachment 112845 [details]
Patch
Comment 5 WebKit Review Bot 2011-10-28 05:20:28 PDT
Comment on attachment 112845 [details]
Patch

Clearing flags on attachment: 112845

Committed r98718: <http://trac.webkit.org/changeset/98718>
Comment 6 WebKit Review Bot 2011-10-28 05:20:33 PDT
All reviewed patches have been landed.  Closing bug.