Bug 70974

Summary: IndexedDB: Database metadata changes should be tied to transaction
Product: WebKit Reporter: Joshua Bell <jsbell>
Component: New BugsAssignee: Joshua Bell <jsbell>
Status: RESOLVED FIXED    
Severity: Normal CC: dgrogan, hans, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joshua Bell
Reported 2011-10-26 15:52:44 PDT
IndexedDB: Database metadata changes should be tied to transaction
Attachments
Patch (18.33 KB, patch)
2011-10-26 16:01 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Patch (18.52 KB, patch)
2011-10-28 11:26 PDT, Joshua Bell 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joshua Bell
Comment 1 2011-10-26 16:01:56 PDT
Created attachment 112610 [details] Patch
Joshua Bell
Comment 2 2011-10-26 17:18:45 PDT
Suggestions for additional tests welcome.
Joshua Bell
Comment 3 2011-10-27 16:31:15 PDT
Chromium test that verifies the fix added at: http://codereview.chromium.org/8341092
Hans Wennborg
Comment 4 2011-10-28 08:48:30 PDT
Looks good to me.
Joshua Bell
Comment 5 2011-10-28 10:21:18 PDT
Comment on attachment 112610 [details] Patch tony@, can you r/cq?
Tony Chang
Comment 6 2011-10-28 10:56:02 PDT
Comment on attachment 112610 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112610&action=review > LayoutTests/storage/indexeddb/open-during-transaction.html:92 > +var successfullyParsed = true; Nit: You don't need to add this anymore. > LayoutTests/storage/indexeddb/version-change-abort.html:96 > +var successfullyParsed = true; Ditto
Joshua Bell
Comment 7 2011-10-28 11:26:41 PDT
Created attachment 112883 [details] Patch
Joshua Bell
Comment 8 2011-10-28 11:28:12 PDT
Comment on attachment 112883 [details] Patch thanks tony@ - it required slightly non-trivial tweak due to exception handling. One more try?
WebKit Review Bot
Comment 9 2011-10-28 12:22:42 PDT
Comment on attachment 112883 [details] Patch Clearing flags on attachment: 112883 Committed r98749: <http://trac.webkit.org/changeset/98749>
WebKit Review Bot
Comment 10 2011-10-28 12:22:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.