Bug 70959

Summary: JS Test Harness: Remove js-test-post-function.js
Product: WebKit Reporter: Erik Arvidsson <arv>
Component: Tools / TestsAssignee: Erik Arvidsson <arv>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70944    
Attachments:
Description Flags
Patch ojan: review+, webkit.review.bot: commit-queue-

Erik Arvidsson
Reported 2011-10-26 13:06:28 PDT
js-test-post-function.js only contains the function isSuccessfullyParsed. By moving this to js-test-pre.js we can remove that file.
Attachments
Patch (126.56 KB, patch)
2011-10-26 14:55 PDT, Erik Arvidsson 		ojan: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Erik Arvidsson
Comment 1 2011-10-26 14:55:28 PDT
Created attachment 112602 [details] Patch
Ojan Vafai
Comment 2 2011-10-26 15:11:55 PDT
Comment on attachment 112602 [details] Patch If we wrap waitUntilDone/notifyDone we won't need this method at all, right? It seems to me people only use it to allow js-tests that use waitUntilDone (e.g. because they need a setTimeout). In either case, this patch is certainly a step in that direction.
Erik Arvidsson
Comment 3 2011-10-26 15:55:50 PDT
(In reply to comment #2) > If we wrap waitUntilDone/notifyDone we won't need this method at all, right? Correct, this should go away eventually.
WebKit Review Bot
Comment 4 2011-10-27 07:38:13 PDT
Comment on attachment 112602 [details] Patch Attachment 112602 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10227541 New failing tests: storage/indexeddb/exception-in-event-aborts.html
Erik Arvidsson
Comment 5 2011-10-28 10:36:03 PDT
Committed r98733: <http://trac.webkit.org/changeset/98733>
Kent Tamura
Comment 6 2011-10-31 18:44:46 PDT
(In reply to comment #5) > Committed r98733: <http://trac.webkit.org/changeset/98733> It removed a lot of ChangeLog entries. http://trac.webkit.org/changeset/98733/trunk/LayoutTests/ChangeLog
Erik Arvidsson
Comment 7 2011-10-31 18:51:38 PDT
Ouch, do you want me to restore that?
Kent Tamura
Comment 8 2011-10-31 18:53:03 PDT
Yes, please :-)
Erik Arvidsson
Comment 9 2011-11-01 10:35:21 PDT
Restored in http://trac.webkit.org/changeset/98976
Note You need to log in before you can comment on or make changes to this bug.