Bug 70952 – [Qt] Support the Web Open Font Format (WOFF)

• Component: Text
• Status: RESOLVED INVALID

[Helder Correia]

Support for this format exists in platform/graphics/WOFFFileFormat*. (patch coming)

[Helder Correia]

Created attachment 112577 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 112577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112577&action=review

> Source/WebCore/WebCore.pri:144
> +LIBS += -lz

So we are introducing another dependency... I guess it is alright, but can you check with Simon?

[Simon Hausmann]

Comment on attachment 112577 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112577&action=review

>> Source/WebCore/WebCore.pri:144

> 
> So we are introducing another dependency... I guess it is alright, but can you check with Simon?

This breaks the (native) build on Windows and technically it also requires changes on non-Windows to get the include path right. zlib.h isn't _guaranteed_ to be in /usr/include strictly speaking. If possible we should be using pkg-config then (and I guess on mac we can rely on fixed paths).

Options for Windows I can think of:

1) No support the feature there (urgh)
2) Pull in src/3rdparty/zlib.pri from the Qt sources (tricky)
3) In addition to 1 or 2, introduce the _option_ of building against a shared zlib on Windows with the ability to specify the include path and library path (or make take implicitly through INCLUDES/LIBS env)

[Eric Seidel (no email)]

Comment on attachment 112577 [details]
Patch

Simon's comments imply this should be r-.

[Chen Zhixiang]

New regression level down occurred!

We have applied the patch a few month ago, and it goes well with html5test.com & css3test.com which both use WOFF web fonts.

But now, all sites suddenly broken down.

QtWebKit-2.3.2, which has contained this patch, built based upon Qt-4.8.x, also fails on css3test.com.

Since css3test.com uses web font files hosted on Google, i surpose that the font file formats have changed recently???

[Chen Zhixiang]

css3test.com uses "text-shadow: 0 -.1em .2em black;", the newest Chrome 29.0.1547.57 m cannot display this text-shadow effect, while Firefox 23.0.1 can.

[Chen Zhixiang]

Created attachment 209751 [details]
qtwebkit-2.3.2 fails to render some text of css3test.com

[Chen Zhixiang]

Created attachment 209753 [details]
Dump of css3test.com

qtwebkit-2.3.2 config: -platform xlibgl -gl-viewport -graphicsbased -viewport-update-mode Full -no-compositing,

-platform xlib has no problem.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.