Bug 70936

Summary:

Web Inspector: [refactoring] TextPrompt: ensure encapsulation, extract history management

Product:

WebKit

Reporter:

Alexander Pavlov (apavlov) <apavlov>

Component:

Web Inspector (Deprecated)

Assignee:

Alexander Pavlov (apavlov) <apavlov>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Suggested solution	pfeldman: review-
[PATCH] Comments addressed	pfeldman: review+

Alexander Pavlov (apavlov)

Reported 2011-10-26 09:26:59 PDT

Patch to follow.

Attachments
[PATCH] Suggested solution (41.32 KB, patch) 2011-10-28 07:28 PDT, Alexander Pavlov (apavlov)	pfeldman: review-	Details Formatted Diff Diff
[PATCH] Comments addressed (45.36 KB, patch) 2011-10-31 04:37 PDT, Alexander Pavlov (apavlov)	pfeldman: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alexander Pavlov (apavlov)

Comment 1 2011-10-28 07:28:51 PDT

Created attachment 112860 [details] [PATCH] Suggested solution

Pavel Feldman

Comment 2 2011-10-31 02:07:49 PDT

Comment on attachment 112860 [details] [PATCH] Suggested solution View in context: https://bugs.webkit.org/attachment.cgi?id=112860&action=review > Source/WebCore/inspector/front-end/TextPrompt.js:185 > + _onKeyDown: function(event) rename to onKeyDown and allow overriding for complex cases. > Source/WebCore/inspector/front-end/TextPrompt.js:525 > + this.commitOnTabWithSuggestion = false; Could you please implement it using setCommitOn... on the TextPromptWithHistory? > Source/WebCore/inspector/front-end/TextPrompt.js:531 > + this.coalesceHistoryDups = true; nit: Dupes?

Alexander Pavlov (apavlov)

Comment 3 2011-10-31 04:37:40 PDT

Created attachment 113039 [details] [PATCH] Comments addressed

Alexander Pavlov (apavlov)

Comment 4 2011-10-31 08:09:27 PDT

Committed r98856: <http://trac.webkit.org/changeset/98856>

Note You need to log in before you can comment on or make changes to this bug.