Summary: | [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Balazs Kelemen <kbalazs> | ||||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | abarth, bank, dpranke, kkristof, ojan, ossy, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 64491 | ||||||||||
Attachments: |
|
Description
Balazs Kelemen
2011-10-26 06:01:26 PDT
Ok, I did not add a new line, sorry for the noise :) BTW, don't you think we should check the expectations file for new line at the end and die with a nice error message if it doesn't have it? Created attachment 113638 [details]
proposed fix
As discussed with Balazs I renamed the bug title to be consistent with the patch. Balazs, please reupload the patch with a new changelog. Created attachment 113648 [details]
proposed fix
Comment on attachment 113648 [details]
proposed fix
Seems reasonable, but we need a test.
Created attachment 113852 [details]
proposed fix
Comment on attachment 113852 [details]
proposed fix
Would be nicer to make all the test expectations files not require a newline, but this is fine.
Comment on attachment 113852 [details] proposed fix Clearing flags on attachment: 113852 Committed r99469: <http://trac.webkit.org/changeset/99469> All reviewed patches have been landed. Closing bug. Comment on attachment 113852 [details]
proposed fix
Yeah, making it not required would have been a better fix, but OK.
|