Summary: | Fix editing/selection/caret-mode-paragraph-keys-navigation.html for Mac | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | HTML Editing | Assignee: | Ryosuke Niwa <rniwa> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cshu, eric, ojan, tkent, tonikitoo, tony, webkit.review.bot, xji | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-10-26 01:12:54 PDT
Created attachment 112467 [details]
fixes the test
Comment on attachment 112467 [details]
fixes the test
OK. What about Apple Mac?
Comment on attachment 112467 [details] fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=112467&action=review > LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html:43 > + var modifierForWordGranularity = navigator.platform == "MacIntel" ? "altKey" : "ctrlKey"; eventSender.keyDown() can have a single modifier name for such platform-dependent keys . We already have the followings: "addSelectionKey" (equivalent to metaKey in Mac, ctrlKey in Windows) "rangeSelectionKey" (equivalent to shiftKey in Mac and Windows) (From http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree) Why is this only failing on Chromium Mac? Is it skipped on AppleMac? Comment on attachment 112467 [details] fixes the test View in context: https://bugs.webkit.org/attachment.cgi?id=112467&action=review >> LayoutTests/editing/selection/caret-mode-paragraph-keys-navigation.html:43 >> + var modifierForWordGranularity = navigator.platform == "MacIntel" ? "altKey" : "ctrlKey"; > > eventSender.keyDown() can have a single modifier name for such platform-dependent keys . We already have the followings: > "addSelectionKey" (equivalent to metaKey in Mac, ctrlKey in Windows) > "rangeSelectionKey" (equivalent to shiftKey in Mac and Windows) > (From http://trac.webkit.org/wiki/Writing%20Layout%20Tests%20for%20DumpRenderTree) That might be a good idea. (In reply to comment #4) > Why is this only failing on Chromium Mac? Is it skipped on AppleMac? According to the comment in Skipped, Apple Mac doesn't support the DRT method. Comment on attachment 112467 [details] fixes the test Clearing flags on attachment: 112467 Committed r98457: <http://trac.webkit.org/changeset/98457> All reviewed patches have been landed. Closing bug. |