Bug 70865

Summary:

JSEventTarget.cpp has a bunch of unnessary includes

Product:

WebKit

Reporter:

Adam Barth <abarth>

Component:

New Bugs

Assignee:

Adam Barth <abarth>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, crogers, dominicc, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Adam Barth

Reported 2011-10-25 18:06:33 PDT

JSEventTarget.cpp has a bunch of unnessary includes

Attachments
Patch (5.19 KB, patch) 2011-10-25 18:08 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Patch for landing (5.19 KB, patch) 2011-10-25 18:27 PDT, Adam Barth	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Adam Barth

Comment 1 2011-10-25 18:08:52 PDT

Created attachment 112438 [details] Patch

Eric Seidel (no email)

Comment 2 2011-10-25 18:18:08 PDT

Comment on attachment 112438 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112438&action=review > Source/WebCore/webaudio/JavaScriptAudioNode.h:49 > +// FIXME: AudioNode should be introduced at the base of the inheritance hierarchy (i.e., as a base class for AudioNode). I'm not sure this makes sense? You use AudioNode twice?

Adam Barth

Comment 3 2011-10-25 18:20:35 PDT

> I'm not sure this makes sense? You use AudioNode twice? Yeah, I meant EventTarget the first time.

Adam Barth

Comment 4 2011-10-25 18:27:06 PDT

Created attachment 112440 [details] Patch for landing

WebKit Review Bot

Comment 5 2011-10-25 20:06:07 PDT

Comment on attachment 112440 [details] Patch for landing Clearing flags on attachment: 112440 Committed r98427: <http://trac.webkit.org/changeset/98427>

WebKit Review Bot

Comment 6 2011-10-25 20:06:11 PDT

All reviewed patches have been landed. Closing bug.

Chris Rogers

Comment 7 2011-10-25 21:49:28 PDT

Adam, FYI, Dominic and I have been talking about making JavaScriptAudioNode *not* be an EventTarget at all. But instead use a Callback instead of EventListener

Adam Barth

Comment 8 2011-10-25 22:01:02 PDT

Even better. BTW, is it too late to rename the interface? Having "JavaScript" in an interface name doesn't make much sense. (Imagine Python bindings for the DOM.)

Chris Rogers

Comment 9 2011-10-26 10:23:42 PDT

(In reply to comment #8) > Even better. > > BTW, is it too late to rename the interface? Having "JavaScript" in an interface name doesn't make much sense. (Imagine Python bindings for the DOM.) I agree that the name isn't the best. Unfortunately, JavaScriptAudioNode is one of the most common nodes people are using, so if we do change the name then I want to provide a deprecation path where the old name (as well as the new name) continues to work for a period of time.

Eric Seidel (no email)

Comment 10 2011-10-26 10:31:52 PDT

Deprecation path seems OK. They talk about how the future is always larger than the past. :) So seems like if we ever want to have other languages in the browser, JavaScript is a bad interface prefix. :)

Note You need to log in before you can comment on or make changes to this bug.