Bug 70853 – Make MutationObserverEntry a class instead of a struct to fix clang build

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Klein]

Make MutationObserverEntry a class instead of a struct to fix clang build

[Adam Klein]

Created attachment 112406 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 112406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112406&action=review

> Source/WebCore/dom/NodeRareData.h:93
> +class MutationObserverEntry {
> +public:

We should probably make observer and options private if we're making this a class.

[Adam Klein]

Comment on attachment 112406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112406&action=review

>> Source/WebCore/dom/NodeRareData.h:93
>> +public:
> 
> We should probably make observer and options private if we're making this a class.

We're "making it a class" only in the sense that we're using the keyword "class" here to quiet the compiler.  It's still logically a struct with a few helper methods.

If you'd rather I change the forward-declaration I can do that too; I mainly didn't do that because I didn't know how to sort it with the rest of the forward decls there :)

[Ryosuke Niwa]

(In reply to comment #3)
> If you'd rather I change the forward-declaration I can do that too; I mainly didn't do that because I didn't know how to sort it with the rest of the forward decls there :)

Okay, then I'd prefer that. Structs should probably appear after classes.

[Adam Klein]

Created attachment 112413 [details]
Patch

[WebKit Review Bot]

Comment on attachment 112413 [details]
Patch

Clearing flags on attachment: 112413

Committed r98402: <http://trac.webkit.org/changeset/98402>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.