Bug 70818

Summary: [chromium] WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
Product: WebKit Reporter: Michal Mocny <mmocny>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, kbr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Michal Mocny
Reported 2011-10-25 10:01:43 PDT
WebGraphicsContext3D setVisibilityCHROMIUM extension changed to pure virtual.
Attachments
Patch (1.89 KB, patch)
2011-10-25 10:03 PDT, Michal Mocny 		no flags
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2011-10-25 10:15 PDT, Michal Mocny 		no flags
DetailsFormatted DiffDiff
Patch (1.41 KB, patch)
2011-10-25 10:34 PDT, Michal Mocny 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michal Mocny
Comment 1 2011-10-25 10:03:13 PDT
Created attachment 112349 [details] Patch
WebKit Review Bot
Comment 2 2011-10-25 10:05:16 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Michal Mocny
Comment 3 2011-10-25 10:08:28 PDT
This patch is the last of the three patch set: 1. https://bugs.webkit.org/show_bug.cgi?id=70635 2. http://codereview.chromium.org/8373006 3. This patch
Michal Mocny
Comment 4 2011-10-25 10:10:15 PDT
Also, WebKit Sheriff (jchaffraix) LGTMed the chromium_rev roll.
Nat Duca
Comment 5 2011-10-25 10:11:28 PDT
Comment on attachment 112349 [details] Patch Unofficially looks good. I'll see if I can rev the deps.
Michal Mocny
Comment 6 2011-10-25 10:15:06 PDT
Created attachment 112352 [details] Patch
Michal Mocny
Comment 7 2011-10-25 10:15:50 PDT
Removed the deps roll from this patch.
Kenneth Russell
Comment 8 2011-10-25 10:22:17 PDT
Comment on attachment 112352 [details] Patch Looks fine as long as it compiles. r=me
WebKit Review Bot
Comment 9 2011-10-25 10:29:10 PDT
Comment on attachment 112352 [details] Patch Attachment 112352 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10213257
Michal Mocny
Comment 10 2011-10-25 10:34:19 PDT
Created attachment 112357 [details] Patch
Kenneth Russell
Comment 11 2011-10-25 11:20:57 PDT
Comment on attachment 112357 [details] Patch OK.
WebKit Review Bot
Comment 12 2011-10-25 13:29:31 PDT
Comment on attachment 112357 [details] Patch Clearing flags on attachment: 112357 Committed r98384: <http://trac.webkit.org/changeset/98384>
WebKit Review Bot
Comment 13 2011-10-25 13:29:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.