Bug 70812

Summary: Web Inspector: JS exception in JavaScriptSourceFrame.onShowPopover/showObjectPopover()
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, podivilov, rik, timothy, yurys
Priority: P2 Keywords: Regression
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch pfeldman: review+

Andrey Kosyakov
Reported 2011-10-25 05:02:59 PDT
There's a race condition in showObjectPopover() -- sometimes, popover may be hidden while a popover expression is being evaluated in the inspected page. In this case, _highlightElement becomes undefined and this._highlightElement.addStyleClass() call in showObjectPopover() results in an exception.
Attachments
patch (1.51 KB, patch)
2011-10-25 05:05 PDT, Andrey Kosyakov 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andrey Kosyakov
Comment 1 2011-10-25 05:05:05 PDT
Created attachment 112323 [details] patch
Andrey Kosyakov
Comment 2 2011-10-25 06:02:53 PDT
A variation of the patch landed manually as r98333: http://trac.webkit.org/changeset/98333
Note You need to log in before you can comment on or make changes to this bug.