Bug 70747

Summary: check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
Product: WebKit Reporter: Nat Duca <nduca>
Component: WebKit Misc.Assignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, levin, ojan, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch tony: review+, levin: commit-queue-

Nat Duca
Reported 2011-10-24 11:28:16 PDT
WebUnitTests.h has WEBKIT_EXPORT's for testing purposes. This makes check-webkit-style sad. On this bug, we discussed adding a WEBKIT_EXPORT_PRIVATE to avoid this: https://bugs.webkit.org/show_bug.cgi?id=70688 However, the conclusion was that we should probably just make cws not complain about test/ exports.
Attachments
Patch (2.78 KB, patch)
2011-10-24 11:55 PDT, David Levin 		tony: review+
levin: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-10-24 11:55:08 PDT
Created attachment 112221 [details] Patch
Tony Chang
Comment 2 2011-10-24 11:56:55 PDT
Comment on attachment 112221 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112221&action=review > Tools/Scripts/webkitpy/style/checkers/cpp.py:1607 > 'WEBKIT_EXPORT should only appear in the chromium public directory.') Nit: Do we want to update the error text?
David Levin
Comment 3 2011-10-24 11:59:33 PDT
Comment on attachment 112221 [details] Patch ok I'll add " (or tests)"
David Levin
Comment 4 2011-10-24 12:01:34 PDT
Committed as http://trac.webkit.org/changeset/98264
Note You need to log in before you can comment on or make changes to this bug.