Bug 70741 – Remove getOwnPropertySlotVirtual

• Component: JavaScriptCore
• Status: RESOLVED FIXED

[Mark Hahnenberg]

Now that we have an entry in the MethodTable for both versions of getOwnPropertySlot, we can remove their virtual counterparts and replace all call sites with an explicit lookup in the MethodTable.

[Mark Hahnenberg]

Created attachment 112404 [details]
Patch

[Geoffrey Garen]

Comment on attachment 112404 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112404&action=review

r=me

> Source/JavaScriptCore/API/JSCallbackObject.h:178
> +    const MethodTable* methodTable() const
> +    {
> +        return Parent::methodTable();
> +    }

I believe "using Parent::methodTable;" would work here, and be slightly more precise about what you mean.

[Mark Hahnenberg]

Committed r98501: <http://trac.webkit.org/changeset/98501>

[Csaba Osztrogonác]

It seems it broke bindings-tests on all bot. Could you fix it, please?

[Philippe Normand]

(In reply to comment #4)
> It seems it broke bindings-tests on all bot. Could you fix it, please?

Looks like the tests only need a reset. I can land it unless someone objects.

[Philippe Normand]

(In reply to comment #5)
> (In reply to comment #4)
> > It seems it broke bindings-tests on all bot. Could you fix it, please?
> 
> Looks like the tests only need a reset. I can land it unless someone objects.

Landed http://trac.webkit.org/changeset/98552